Skip to content

net/mlx5: flow fast path validation

Dariusz Sosnowski dpdk-dev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 1 replyIn review
  2. v2 posting 2/28 patches 0 repliesSuperseded
  3. v2 posting 1/21 patch 1 replyApplied
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v19 patches1 replySuperseded

Changes in v3 from the cover letter

- Rebased on 24.07-rc1.
- Removed Depends-on tag for already marged ethdev patch.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8net/mlx5: extract target port validationdrivers/net/mlx5/mlx5_flow_hw.c+40 -230 replies
2/8net/mlx5: extract queue index validationdrivers/net/mlx5/mlx5_flow.c drivers/net/mlx5/mlx5_flow.h+44 -180 replies
3/8net/mlx5: store pattern template itemsdrivers/net/mlx5/mlx5_flow.h drivers/net/mlx5/mlx5_flow_hw.c+31 -00 replies
4/8net/mlx5: store original actions in templatedrivers/net/mlx5/mlx5_flow.h drivers/net/mlx5/mlx5_flow_hw.c+12 -00 replies
5/8net/mlx5: store expected type on indirect actiondrivers/net/mlx5/mlx5_flow.h drivers/net/mlx5/mlx5_flow_hw.c+24 -20 replies
6/8net/mlx5: store modify field actiondrivers/net/mlx5/mlx5_flow.h drivers/net/mlx5/mlx5_flow_hw.c+5 -10 replies
7/8common/mlx5: add debug mode indicatordrivers/common/mlx5/mlx5_common.h+13 -00 replies
8/8net/mlx5: add async flow operation validationdoc/guides/rel_notes/release_24_07.rst drivers/net/mlx5/mlx5_flow_hw.c+488 -40 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchOri Kam
1/8A-b
2/8A-b
3/8A-b
4/8A-b
5/8A-b
6/8A-b
7/8A-b
8/8A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/8] net/mlx5: flow fast path validation

This patchset adds validations for flow items and actions supplied by the user to fast path async flow API functions implemented in mlx5 PMD.

- Patches 1-7: Prepares mlx5 PMD for adding fast path validations. Specifically:

- Required functionality for validating queue indexes and target represented ports are extracted for reuse.
- Additional info, required for validation, is stored in pattern and actions templates.
- Introduces mlx5_fp_debug_enabled() function for checking if mlx5 PMD was compiled in debug mode.

- Patch 8: Introduce validations to:

- rte_flow_async_create()
- rte_flow_async_create_by_index()
- rte_flow_async_actions_update()
- rte_flow_async_destroy()

These validations are enabled if and only if RTE_LIBRTE_MLX5_DEBUG macro is defined during compilation.

v3:
- Rebased on 24.07-rc1.
- Removed Depends-on tag for already marged ethdev patch.

v2:
- Split series 32095 into separate ethdev and mlx5 series.
- Rebased on latest commit in next-net-mlx-main.
- Removed Depends-on tags for already merged mlx5 patch series.

Dariusz Sosnowski (8):
net/mlx5: extract target port validation net/mlx5: extract queue index validation net/mlx5: store pattern template items net/mlx5: store original actions in template net/mlx5: store expected type on indirect action net/mlx5: store modify field action common/mlx5: add debug mode indicator net/mlx5: add async flow operation validation

 doc/guides/rel_notes/release_24_07.rst |   1 +
 drivers/common/mlx5/mlx5_common.h      |  13 +
 drivers/net/mlx5/mlx5_flow.c           |  59 ++-
 drivers/net/mlx5/mlx5_flow.h           |  12 +
 drivers/net/mlx5/mlx5_flow_hw.c        | 620 +++++++++++++++++++++++--
 5 files changed, 657 insertions(+), 48 deletions(-)

--
2.39.2