Skip to content

net: dsa: lantiq_gswip: code improvements

Martin Schiller linux-devicetree lkml netdev 5 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest12 patches 20 repliesApplied 12/12
  2. v413 patches 4 repliesSuperseded
  3. v312 patches 1 replySuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v212 patches0 repliesSuperseded
v113 patches33 repliesSuperseded

Changes in v5 from the cover letter

- merge dt-bindings patches to satisfy 'make dt_bindings_check' and add some improvements suggested by Rob Herring

Patches in v5 All 12 applied

#Subject and filesSizeRepliesApplied
1/12dt-bindings: net: dsa: lantiq,gswip: convert to YAML schemaDocumentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml Documentation/devicetree/bindings/net/dsa/lantiq-gswip.txt MAINTAINERS+203 -1462 repliesApplied
2/12net: dsa: lantiq_gswip: Only allow phy-mode = "internal" on the CPU portdrivers/net/dsa/lantiq_gswip.c+2 -02 repliesApplied
3/12net: dsa: lantiq_gswip: add terminating \n where missingdrivers/net/dsa/lantiq_gswip.c+7 -71 replyApplied
4/12net: dsa: lantiq_gswip: Use dev_err_probe where appropriatedrivers/net/dsa/lantiq_gswip.c+25 -282 repliesApplied
5/12net: dsa: lantiq_gswip: Don't manually call gswip_port_enable()drivers/net/dsa/lantiq_gswip.c+0 -22 repliesApplied
6/12net: dsa: lantiq_gswip: do also enable or disable cpu portdrivers/net/dsa/lantiq_gswip.c+8 -161 replyApplied
7/12net: dsa: lantiq_gswip: Use dsa_is_cpu_port() in gswip_port_change_mtu()drivers/net/dsa/lantiq_gswip.c+1 -21 replyApplied
8/12net: dsa: lantiq_gswip: Change literal 6 to ETH_ALENdrivers/net/dsa/lantiq_gswip.c+1 -11 replyApplied
9/12net: dsa: lantiq_gswip: Consistently use macros for the mac bridge tabledrivers/net/dsa/lantiq_gswip.c+11 -71 replyApplied
10/12net: dsa: lantiq_gswip: Remove dead code from gswip_add_single_port_br()drivers/net/dsa/lantiq_gswip.c+0 -61 replyApplied
11/12net: dsa: lantiq_gswip: Update comments in gswip_port_vlan_filtering()drivers/net/dsa/lantiq_gswip.c+2 -22 repliesApplied
12/12net: dsa: lantiq_gswip: Improve error message in gswip_port_fdb()drivers/net/dsa/lantiq_gswip.c+2 -12 repliesApplied

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchVladimir OlteanHauke MehrtensAndrew LunnRob Herring (Arm)
1/12R-b R-b
2/12R-b A-b
3/12R-b R-b
4/12R-b A-b
5/12R-b A-b
6/12R-b A-b
7/12R-b A-b
8/12R-b A-b
9/12R-b A-b
10/12R-b
11/12R-b A-b
12/12R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v5 thread

Cover letter [PATCH net-next v5 00/12] net: dsa: lantiq_gswip: code improvements

This patchset for the lantiq_gswip driver is a collection of minor fixes and coding improvements by Martin Blumenstingl without any real changes in the actual functionality.

=== Changelog ===
From v4:
- merge dt-bindings patches to satisfy 'make dt_bindings_check' and add some improvements suggested by Rob Herring

From v3:
- convert lantiq,gswip bindings to YAML schema
- Add Hauke's acked-by as mentioned in the cover letter in v1

From v2:
- removed unused variable max_ports in gswip_add_single_port_br()

From v1:
- signal that we only update example code in dt-bindings
- don't use the word 'fix' if not appropriate
- new patch: add terminating '\n' where missing
- renamed MAC_BRIDGE macros to make it obvious which register field is used
- new patch: remove dead code from gswip_add_single_port_br()
- updated error message if FID not found in gswip_port_fdb()

Martin Blumenstingl (8):
net: dsa: lantiq_gswip: Only allow phy-mode = "internal" on the CPU
port
net: dsa: lantiq_gswip: Use dev_err_probe where appropriate
net: dsa: lantiq_gswip: Don't manually call gswip_port_enable()
net: dsa: lantiq_gswip: Use dsa_is_cpu_port() in
gswip_port_change_mtu()
net: dsa: lantiq_gswip: Change literal 6 to ETH_ALEN
net: dsa: lantiq_gswip: Consistently use macros for the mac bridge
table
net: dsa: lantiq_gswip: Update comments in gswip_port_vlan_filtering()
net: dsa: lantiq_gswip: Improve error message in gswip_port_fdb()

Martin Schiller (4):
dt-bindings: net: dsa: lantiq,gswip: convert to YAML schema
net: dsa: lantiq_gswip: add terminating \n where missing
net: dsa: lantiq_gswip: do also enable or disable cpu port
net: dsa: lantiq_gswip: Remove dead code from
gswip_add_single_port_br()

 .../bindings/net/dsa/lantiq,gswip.yaml        | 202 ++++++++++++++++++
 .../bindings/net/dsa/lantiq-gswip.txt         | 146 -------------
 MAINTAINERS                                   |   1 +
 drivers/net/dsa/lantiq_gswip.c                | 123 +++++------
 4 files changed, 258 insertions(+), 214 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
 delete mode 100644 Documentation/devicetree/bindings/net/dsa/lantiq-gswip.txt
Signature · 1 line
2.39.2