Skip to content

target/s390x: Fix tracing header path in TCG mem_helper.c

Philippe Mathieu-Daudé qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 4 repliesIn review
  2. v11 patch 3 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2hw/s390x: Introduce s390_skeys_get|set() helpershw/s390x/s390-skeys.c hw/s390x/trace-events include/hw/s390x/storage-keys.h+41 -00 replies
2/2target/s390x: Use s390_skeys_get|set() helpertarget/s390x/mmu_helper.c target/s390x/tcg/mem_helper.c target/s390x/trace-events+6 -250 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchThomas HuthPaolo Bonzini
SeriesR-b R-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] target/s390x: Fix tracing header path in TCG mem_helper.c

In order to keep trace event headers local to their directory, introduce s390_skeys_get/s390_skeys_set helpers, fixing:

In file included from ../../target/s390x/tcg/mem_helper.c:33:
../../target/s390x/tcg/trace.h:1:10: fatal error: 'trace/trace-target_s390x_tcg.h' file not found

  #include "trace/trace-target_s390x_tcg.h"
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

1 error generated.
ninja: build stopped: subcommand failed.

Philippe Mathieu-Daudé (2):
hw/s390x: Introduce s390_skeys_get|set() helpers target/s390x: Use s390_skeys_get|set() helper

 include/hw/s390x/storage-keys.h | 10 ++++++++++
 hw/s390x/s390-skeys.c           | 27 +++++++++++++++++++++++++++
 target/s390x/mmu_helper.c       | 11 ++---------
 target/s390x/tcg/mem_helper.c   | 16 ++++------------
 hw/s390x/trace-events           |  4 ++++
 target/s390x/trace-events       |  4 ----
 6 files changed, 47 insertions(+), 25 deletions(-)
Signature · 1 line
2.41.0