Skip to content

Only timeout jobs if they run longer than timeout period

Matthew Brost intel-xe 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest11 patches 12 repliesIn review
  2. v510 patches 19 repliesSuperseded
  3. v47 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v36 patches5 repliesSuperseded
v26 patches0 repliesSuperseded
v1 RFC5 patches4 repliesSuperseded

Changes in v6 from the cover letter

- Address John H's latest feedback including a new patch
- Fix CI hooks failure
- Fix assertion failure [4]

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11drm/xe: Add LRC ctx timestamp support functionsdrivers/gpu/drm/xe/xe_lrc.c drivers/gpu/drm/xe/xe_lrc.h+82 -10 replies
2/11drm/xe: Add MI_COPY_MEM_MEM GPU instruction definitionsdrivers/gpu/drm/xe/instructions/xe_mi_commands.h+4 -00 replies
3/11drm/xe: Emit ctx timestamp copy in ring opsdrivers/gpu/drm/xe/xe_ring_ops.c+21 -00 replies
4/11drm/xe: Add ctx timestamp to LRC snapshotdrivers/gpu/drm/xe/xe_lrc.c+6 -00 replies
5/11drm/xe: Add xe_gt_clock_interval_to_ms helperdrivers/gpu/drm/xe/xe_gt_clock.c drivers/gpu/drm/xe/xe_gt_clock.h+21 -00 replies
6/11drm/xe: Improve unexpected state error messagesdrivers/gpu/drm/xe/xe_guc_submit.c+8 -40 replies
7/11drm/xe: Assert runnable state in handle_sched_donedrivers/gpu/drm/xe/xe_guc_submit.c+7 -26 replies
8/11drm/xe: Add GuC state asserts to deregister_exec_queuedrivers/gpu/drm/xe/xe_guc_submit.c+5 -00 replies
9/11drm/xe: Add pending disable assert to handle_sched_donedrivers/gpu/drm/xe/xe_guc_submit.c+1 -00 replies
10/11drm/xe: Add killed, banned, or wedged as stick bit during GuC resetdrivers/gpu/drm/xe/xe_guc_submit.c+3 -10 replies
11/11drm/xe: Sample ctx timestamp to determine if jobs have timed outdrivers/gpu/drm/xe/xe_guc_submit.c+242 -616 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchJonathan Cavitt
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 00/11] Only timeout jobs if they run longer than timeout period

Debugging [1] hit a known flaw in the job timeout mechanism - jobs timeout after a period of time in which they have been submitted to the GuC not how long they have actually been running on the hardware. Attempt to fix this.

Algorithm is as follows:
- Copy ctx timestamp from LRC to saved location at beginning of every job
- On TDR kick jobs off hardware via schedule disable so ctx timestamp is updated
- Compare ctx timestamp to saved ctx timestamp, if jobs having been running less than timeout period re-enable scheduling are restart TDR

New job cancel IGT [2] for testing.

v2:
- Promote to non-RFC as issues which I view as blockers have been resolved
- Address Jani and Michal v1 feedback
- Add GT clock timer calculation
v3:
- More testing
- Fix TDR state machine bugs exposed in testing
- Rebase for CI
v4:
- Address a few comments by John H
- Fix CI failure [3]
v5:
- Include all the patches
v6:
- Address John H's latest feedback including a new patch
- Fix CI hooks failure
- Fix assertion failure [4]

Matt

[1] https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/799
[2] https://patchwork.freedesktop.org/series/134640/
[3] https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-134642v1/shard-dg2-433/igt@[email protected]
[4] https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/799#note_2445590

Matthew Brost (11):
drm/xe: Add LRC ctx timestamp support functions
drm/xe: Add MI_COPY_MEM_MEM GPU instruction definitions drm/xe: Emit ctx timestamp copy in ring ops
drm/xe: Add ctx timestamp to LRC snapshot
drm/xe: Add xe_gt_clock_interval_to_ms helper
drm/xe: Improve unexpected state error messages
drm/xe: Assert runnable state in handle_sched_done drm/xe: Add GuC state asserts to deregister_exec_queue drm/xe: Add pending disable assert to handle_sched_done drm/xe: Add killed, banned, or wedged as stick bit during GuC reset drm/xe: Sample ctx timestamp to determine if jobs have timed out

 .../gpu/drm/xe/instructions/xe_mi_commands.h  |   4 +
 drivers/gpu/drm/xe/xe_gt_clock.c              |  20 ++
 drivers/gpu/drm/xe/xe_gt_clock.h              |   1 +
 drivers/gpu/drm/xe/xe_guc_submit.c            | 334 ++++++++++++++----
 drivers/gpu/drm/xe/xe_lrc.c                   |  84 ++++-
 drivers/gpu/drm/xe/xe_lrc.h                   |   5 +
 drivers/gpu/drm/xe/xe_ring_ops.c              |  21 ++
 7 files changed, 400 insertions(+), 69 deletions(-)
Signature · 1 line
2.34.1