Skip to content

nfs/nfsd: add support for LOCALIO

Mike Snitzer linux-nfs 16 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v16 Latest26 patches 1 replyIn review
  2. v1526 patches 52 repliesSuperseded
  3. v1425 patches 47 repliesSuperseded
Earlier versions · 13
VersionPostedPatchesRepliesStatus
v1319 patches35 repliesSuperseded
v1224 patches29 repliesSuperseded
v1120 patches56 repliesSuperseded
v1019 patches0 repliesSuperseded
v919 patches24 repliesSuperseded
v818 patches13 repliesSuperseded
v720 patches19 repliesSuperseded
v618 patches19 repliesSuperseded
v519 patches25 repliesSuperseded
v418 patches2 repliesSuperseded
v318 patches0 repliesSuperseded
v2 RFC15 patches10 repliesSuperseded
v129 patches22 repliesSuperseded

Patches in v16 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/26nfs_common: factor out nfs_errtbl and nfs_stat_to_errnofs/nfs/Kconfig fs/nfs/nfs2xdr.c fs/nfs/nfs3xdr.c +5 more+109 -1600 replies
2/26nfs_common: factor out nfs4_errtbl and nfs4_stat_to_errnofs/nfs/nfs4xdr.c fs/nfs_common/common.c include/linux/nfs_common.h+68 -670 replies
3/26nfs: factor out {encode,decode}_opaque_fixed to nfs_xdr.hfs/nfs/flexfilelayout/flexfilelayout.c fs/nfs/nfs4xdr.c include/linux/nfs_xdr.h+19 -200 replies
4/26NFSD: Handle @rqstp == NULL in check_nfsd_access()fs/nfsd/export.c+25 -50 replies
5/26NFSD: Refactor nfsd_setuser_and_check_port()fs/nfsd/nfsfh.c+10 -90 replies
6/26NFSD: Avoid using rqstp->rq_vers in nfsd_set_fh_dentry()fs/nfsd/nfsfh.c+4 -40 replies
7/26NFSD: Short-circuit fh_verify tracepoints for LOCALIOfs/nfsd/trace.h+10 -80 replies
8/26nfsd: factor out __fh_verify to allow NULL rqstp to be passedfs/nfsd/nfsfh.c+60 -310 replies
9/26nfsd: add nfsd_file_acquire_local()fs/nfsd/filecache.c fs/nfsd/filecache.h fs/nfsd/nfsfh.c +1 more+92 -70 replies
10/26nfsd: add nfsd_serv_try_get and nfsd_serv_putfs/nfsd/netns.h fs/nfsd/nfssvc.c+50 -10 replies
11/26SUNRPC: remove call_allocate() BUG_ONsnet/sunrpc/clnt.c+0 -60 replies
12/26SUNRPC: add svcauth_map_clnt_to_svc_cred_localinclude/linux/sunrpc/svcauth.h net/sunrpc/svcauth.c+33 -00 replies
13/26SUNRPC: replace program list with program arrayfs/nfsd/nfsctl.c fs/nfsd/nfsd.h fs/nfsd/nfssvc.c +4 more+67 -550 replies
14/26nfs_common: add NFS LOCALIO auxiliary protocol enablementfs/Kconfig fs/nfs_common/Makefile fs/nfs_common/nfslocalio.c +1 more+178 -00 replies
15/26nfs_common: prepare for the NFS client to use nfsd_file for LOCALIOfs/nfs_common/nfslocalio.c fs/nfsd/filecache.c fs/nfsd/filecache.h +2 more+81 -20 replies
16/26nfsd: add LOCALIO supportfs/nfsd/Makefile fs/nfsd/filecache.c fs/nfsd/localio.c +5 more+134 -30 replies
17/26nfsd: implement server support for NFS_LOCALIO_PROGRAMfs/nfsd/localio.c fs/nfsd/nfsd.h fs/nfsd/nfssvc.c +1 more+110 -10 replies
18/26nfs: pass struct nfsd_file to nfs_init_pgio and nfs_init_commitfs/nfs/filelayout/filelayout.c fs/nfs/flexfilelayout/flexfilelayout.c fs/nfs/internal.h +4 more+22 -150 replies
19/26nfs: add LOCALIO supportfs/nfs/Makefile fs/nfs/client.c fs/nfs/internal.h +8 more+773 -00 replies
20/26nfs: enable localio for non-pNFS IOfs/nfs/pagelist.c fs/nfs/write.c+12 -20 replies
21/26pnfs/flexfiles: enable localio supportfs/nfs/flexfilelayout/flexfilelayout.c fs/nfs/flexfilelayout/flexfilelayoutdev.c+52 -40 replies
22/26nfs/localio: use dedicated workqueues for filesystem read and writefs/nfs/inode.c fs/nfs/internal.h fs/nfs/localio.c+93 -400 replies
23/26nfs: implement client support for NFS_LOCALIO_PROGRAMfs/nfs/client.c fs/nfs/localio.c+132 -60 replies
24/26nfs: add Documentation/filesystems/nfs/localio.rstDocumentation/filesystems/nfs/localio.rst+203 -00 replies
25/26nfs: add FAQ section to Documentation/filesystems/nfs/localio.rstDocumentation/filesystems/nfs/localio.rst+86 -00 replies
26/26nfs: add "NFS Client and Server Interlock" section to localio.rstDocumentation/filesystems/nfs/localio.rst+68 -01 reply

Reviews trailers per patch

All 26 patches have a Reviewed-by or Acked-by.

PatchJeff LaytonNeilBrownChuck Lever
1/26R-b R-b
2/26R-b R-b
3/26R-b R-b
4/26R-b
5/26R-b
6/26R-b R-b
7/26A-b R-b
8/26R-b
9/26R-b
10/26R-b R-b R-b
11/26R-b R-b
12/26R-b R-b R-b
13/26R-b A-b
14/26R-b
15/26R-b R-b
16/26R-b A-b
17/26R-b A-b
18/26R-b R-b
19/26R-b
20/26R-b R-b
21/26R-b R-b
22/26R-b
23/26R-b
24/26R-b R-b
25/26R-b R-b
26/26R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v16 thread

Cover letter [PATCH v16 00/26] nfs/nfsd: add support for LOCALIO

Hi,

These latest changes are available in my git tree here:
https://git.kernel.org/pub/scm/linux/kernel/git/snitzer/linux.git/log/?h=nfs-localio-for-next

The NFSD changes have all settled with this v16. This is the natural pivot point for NFS client review to be completed (my understanding from Trond is that Anna will be taking a close look).

Changes since v15, which are reflected in the top 3 commits on this branch:
https://git.kernel.org/pub/scm/linux/kernel/git/snitzer/linux.git/log/?h=nfs-localio-for-next.v15-with-fixups

- Fixes to nfs_to to follow normal operations table pattern Switch 'nfs_to' to a proper pointer that just needs a simple assignment rather than memcpy() to initialize. Updated all 'nfs_to' callers accordingly. Removed the associated 'nfs_to_<nfsd_func>_t' function pointer typedefs that really weren't helpful.

- Removed EXPORT_SYMBOL_GPL for nfsd_serv_put, nfsd_file_put_local and nfsd_file_file (these symbols are only used directly in nfsd, but they are exposed to nfs via 'nfs_to' operations table).

- A few sparse fixes dealing primarily with rcu usage.

- nfs_common: push nfsd_open_local_fh rcu requirements to caller. Now nfs_open_local_fh safely gets reference to nfsd_serv and then drops rcu before its call to nfs_to->nfsd_open_local_fh. If that call fails then nfs_to->nfsd_serv_put is needed. This cleans up the awkward rcu bouncing that was in nfsd_open_local_fh but introduces the need for both nfs_to->nfsd_serv_try_get and nfs_to->nfsd_serv_put.

All review appreciated, thanks!
Mike

Chuck Lever (2):
NFSD: Avoid using rqstp->rq_vers in nfsd_set_fh_dentry()
NFSD: Short-circuit fh_verify tracepoints for LOCALIO

Mike Snitzer (12):
nfs_common: factor out nfs_errtbl and nfs_stat_to_errno
nfs_common: factor out nfs4_errtbl and nfs4_stat_to_errno
nfs: factor out {encode,decode}_opaque_fixed to nfs_xdr.h
nfsd: add nfsd_serv_try_get and nfsd_serv_put
SUNRPC: remove call_allocate() BUG_ONs
nfs_common: add NFS LOCALIO auxiliary protocol enablement
nfs_common: prepare for the NFS client to use nfsd_file for LOCALIO
nfsd: implement server support for NFS_LOCALIO_PROGRAM
nfs: pass struct nfsd_file to nfs_init_pgio and nfs_init_commit
nfs: implement client support for NFS_LOCALIO_PROGRAM
nfs: add Documentation/filesystems/nfs/localio.rst
nfs: add "NFS Client and Server Interlock" section to localio.rst

NeilBrown (5):
NFSD: Handle @rqstp == NULL in check_nfsd_access()
NFSD: Refactor nfsd_setuser_and_check_port()
nfsd: factor out __fh_verify to allow NULL rqstp to be passed
nfsd: add nfsd_file_acquire_local()
SUNRPC: replace program list with program array

Trond Myklebust (4):
nfs: enable localio for non-pNFS IO
pnfs/flexfiles: enable localio support
nfs/localio: use dedicated workqueues for filesystem read and write
nfs: add FAQ section to Documentation/filesystems/nfs/localio.rst

Weston Andros Adamson (3):
SUNRPC: add svcauth_map_clnt_to_svc_cred_local
nfsd: add LOCALIO support
nfs: add LOCALIO support

 Documentation/filesystems/nfs/localio.rst | 357 ++++++++++
 fs/Kconfig                                |  23 +
 fs/nfs/Kconfig                            |   1 +
 fs/nfs/Makefile                           |   1 +
 fs/nfs/client.c                           |  15 +-
 fs/nfs/filelayout/filelayout.c            |   6 +-
 fs/nfs/flexfilelayout/flexfilelayout.c    |  56 +-
 fs/nfs/flexfilelayout/flexfilelayoutdev.c |   6 +
 fs/nfs/inode.c                            |  57 +-
 fs/nfs/internal.h                         |  53 +-
 fs/nfs/localio.c                          | 757 ++++++++++++++++++++++
 fs/nfs/nfs2xdr.c                          |  70 +-
 fs/nfs/nfs3xdr.c                          | 108 +--
 fs/nfs/nfs4xdr.c                          |  84 +--
 fs/nfs/nfstrace.h                         |  61 ++
 fs/nfs/pagelist.c                         |  16 +-
 fs/nfs/pnfs_nfs.c                         |   2 +-
 fs/nfs/write.c                            |  12 +-
 fs/nfs_common/Makefile                    |   5 +
 fs/nfs_common/common.c                    | 134 ++++
 fs/nfs_common/nfslocalio.c                | 172 +++++
 fs/nfsd/Kconfig                           |   1 +
 fs/nfsd/Makefile                          |   1 +
 fs/nfsd/export.c                          |  30 +-
 fs/nfsd/filecache.c                       | 101 ++-
 fs/nfsd/filecache.h                       |   5 +
 fs/nfsd/localio.c                         | 169 +++++
 fs/nfsd/netns.h                           |  12 +-
 fs/nfsd/nfsctl.c                          |  27 +-
 fs/nfsd/nfsd.h                            |   6 +-
 fs/nfsd/nfsfh.c                           | 137 ++--
 fs/nfsd/nfsfh.h                           |   2 +
 fs/nfsd/nfssvc.c                          | 105 ++-
 fs/nfsd/trace.h                           |  21 +-
 fs/nfsd/vfs.h                             |   2 +
 include/linux/nfs.h                       |   9 +
 include/linux/nfs_common.h                |  17 +
 include/linux/nfs_fs_sb.h                 |   9 +
 include/linux/nfs_xdr.h                   |  20 +-
 include/linux/nfslocalio.h                |  74 +++
 include/linux/sunrpc/svc.h                |   7 +-
 include/linux/sunrpc/svcauth.h            |   5 +
 net/sunrpc/clnt.c                         |   6 -
 net/sunrpc/svc.c                          |  68 +-
 net/sunrpc/svc_xprt.c                     |   2 +-
 net/sunrpc/svcauth.c                      |  28 +
 net/sunrpc/svcauth_unix.c                 |   3 +-
 47 files changed, 2454 insertions(+), 409 deletions(-)
 create mode 100644 Documentation/filesystems/nfs/localio.rst
 create mode 100644 fs/nfs/localio.c
 create mode 100644 fs/nfs_common/common.c
 create mode 100644 fs/nfs_common/nfslocalio.c
 create mode 100644 fs/nfsd/localio.c
 create mode 100644 include/linux/nfs_common.h
 create mode 100644 include/linux/nfslocalio.h
Signature · 1 line
2.44.0