Skip to content

target/ppc: Move VSX storage access and compare

Chinmay Rath qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 2 repliesIn review
  2. v24 patches 7 repliesSuperseded
  3. v14 patches 9 repliesSuperseded

Changes in v3 from the cover letter

- Patch 2/4 : Updated the added function do_ea_calc_ra to return modifiable EA, after discussions with Richard.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4target/ppc: Moving VSX scalar storage access insns to decodetree.target/ppc/insn32.decode target/ppc/translate/vsx-impl.c.inc target/ppc/translate/vsx-ops.c.inc+49 -540 replies
2/4target/ppc: Move VSX vector with length storage access insns to decodetree.target/ppc/helper.h target/ppc/insn32.decode target/ppc/mem_helper.c +3 more+94 -451 reply
3/4target/ppc: Move VSX vector storage access insns to decodetree.target/ppc/insn32.decode target/ppc/translate/vsx-impl.c.inc target/ppc/translate/vsx-ops.c.inc+97 -1241 reply
4/4target/ppc: Move VSX fp compare insns to decodetree.target/ppc/fpu_helper.c target/ppc/helper.h target/ppc/insn32.decode +2 more+48 -600 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchRichard Henderson
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] target/ppc: Move VSX storage access and compare

Moving all remaining VSX storage access instructions and all VSX compare instructions of XX3 form with RC field, to decodetree specification.

Change log :

v3:
- Patch 2/4 : Updated the added function do_ea_calc_ra to return modifiable EA, after discussions with Richard.

v2: https://lore.kernel.org/qemu-devel/[email protected]/
- Addressed comments by Richard in v1 :
- Patch 2/4 : Handled proper ea calculation in narrow mode.
Also created a new function for ea calculation instead of inlining, for later use by (p){lx,stx}vp insns.
- Patch 4/4 : Unified helper calls.
- Retained Richard's "Reviewed-by" in patches 1, 3 and 4.

v1: https://lore.kernel.org/qemu-devel/[email protected]/

Chinmay Rath (4):
target/ppc: Moving VSX scalar storage access insns to decodetree. target/ppc: Move VSX vector with length storage access insns to
decodetree.
target/ppc: Move VSX vector storage access insns to decodetree. target/ppc: Move VSX fp compare insns to decodetree.

 target/ppc/helper.h                 |  24 +-
 target/ppc/insn32.decode            |  41 +++
 target/ppc/fpu_helper.c             |  16 +-
 target/ppc/mem_helper.c             |   8 +-
 target/ppc/translate.c              |  15 +
 target/ppc/translate/vsx-impl.c.inc | 416 ++++++++++++++--------------
 target/ppc/translate/vsx-ops.c.inc  |  49 ----
 7 files changed, 287 insertions(+), 282 deletions(-)
Signature · 1 line
2.39.3