Skip to content

KVM: nVMX: Fix nested posted intr vs. HLT

Sean Christopherson kvm lkml 1 version Applied

Status from this message: Applied to kvm-x86 vmx, but it's sitting at the end of the branch in case

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/6KVM: nVMX: Add a helper to get highest pending from Posted Interrupt vectorarch/x86/kvm/vmx/nested.c arch/x86/kvm/vmx/posted_intr.h+13 -20 replies
2/6KVM: nVMX: Request immediate exit iff pending nested event needs injectionarch/x86/include/asm/kvm_host.h arch/x86/kvm/vmx/nested.c arch/x86/kvm/x86.c+4 -40 replies
3/6KVM: VMX: Split out the non-virtualization part of vmx_interrupt_blocked()arch/x86/kvm/vmx/vmx.c arch/x86/kvm/vmx/vmx.h+10 -40 replies
4/6KVM: nVMX: Check for pending posted interrupts when looking for nested eventsarch/x86/kvm/vmx/nested.c+34 -20 replies
5/6KVM: nVMX: Fold requested virtual interrupt check into has_nested_events()arch/x86/include/asm/kvm-x86-ops.h arch/x86/include/asm/kvm_host.h arch/x86/kvm/vmx/main.c +4 more+5 -330 replies
6/6KVM: x86: WARN if a vCPU gets a valid wakeup that KVM can't yet injectarch/x86/kvm/x86.c+4 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] KVM: nVMX: Fix nested posted intr vs. HLT

Fix the nested posted interrupts bug Jim reported a while back[*], where KVM fails to detect that a pending virtual interrupt for a halted L2 is a valid wake event. My original analysis and the basic gits of my hack-a- patch was correct, I just botched a few mundane details (I kept forgetting the PIR is physically contiguous, while the ISR and IRR are not, *sigh*).

[*] https://lore.kernel.org/all/[email protected]

Sean Christopherson (6):
KVM: nVMX: Add a helper to get highest pending from Posted Interrupt
vector
KVM: nVMX: Request immediate exit iff pending nested event needs
injection
KVM: VMX: Split out the non-virtualization part of
vmx_interrupt_blocked()
KVM: nVMX: Check for pending posted interrupts when looking for nested
events
KVM: nVMX: Fold requested virtual interrupt check into
has_nested_events()
KVM: x86: WARN if a vCPU gets a valid wakeup that KVM can't yet inject

 arch/x86/include/asm/kvm-x86-ops.h |  1 -
 arch/x86/include/asm/kvm_host.h    |  3 +-
 arch/x86/kvm/vmx/main.c            |  1 -
 arch/x86/kvm/vmx/nested.c          | 47 ++++++++++++++++++++++++++----
 arch/x86/kvm/vmx/posted_intr.h     | 10 +++++++
 arch/x86/kvm/vmx/vmx.c             | 33 ++++++---------------
 arch/x86/kvm/vmx/vmx.h             |  1 +
 arch/x86/kvm/vmx/x86_ops.h         |  1 -
 arch/x86/kvm/x86.c                 | 19 +++++-------
 9 files changed, 70 insertions(+), 46 deletions(-)

base-commit: af0903ab52ee6d6f0f63af67fa73d5eb00f79b9a

Signature · 1 line
2.45.2.505.gda0bf45e8d-goog