Skip to content

mm: zswap: fixes for global shrinker

Takero Funaki linux-mm lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 3 repliesIn review 1 of 2 applied
  2. v42 patches 4 repliesSuperseded
  3. v32 patches 13 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v26 patches30 repliesSuperseded
v13 patches28 repliesSuperseded

Changes in v4 from the cover letter

- Updated comments and commit logs to clarify expected behaviors (Yosry, Nhat)
- Merged duplicated spin_unlock() in if branches (Nhat)
- Renamed writeback attempts counter (Nhat, Chengming)

Patches in v5 1 of 2 applied

#Subject and filesSizeRepliesApplied
1/2mm: zswap: fix global shrinker memcg iterationmm/zswap.c+44 -241 reply
2/2mm: zswap: fix global shrinker error handling logicmm/zswap.c+33 -72 repliesApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchYosry AhmedChengming ZhouNhat Pham
1/2A-b R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/2] mm: zswap: fixes for global shrinker

This series addresses issues in the zswap global shrinker that could not shrink stored pages. With this series, the shrinker continues to shrink pages until it reaches the accept threshold more reliably, gives much higher writeback when the zswap pool limit is hit.

v5 is additional cleanup on comments I missed in the last thread, and adds Acked-by and Reviewed-by tags into the patch 1.
No behavioral changes have been made since v4:
https://lore.kernel.org/lkml/[email protected]/

Chnaged in v5:
- Cleaned up more comments (Yosry)

Changes in v4:
- Updated comments and commit logs to clarify expected behaviors (Yosry, Nhat)
- Merged duplicated spin_unlock() in if branches (Nhat)
- Renamed writeback attempts counter (Nhat, Chengming)

Changes in v3:
- Extract fixes for shrinker as a separate patch series.
- Fix comments and commit messages. (Chengming, Yosry)
- Drop logic to detect rare doubly advancing cursor. (Yosry)

Changes in v2:
mm: zswap: fix global shrinker memcg iteration:
- Change the loop style (Yosry, Nhat, Shakeel)
mm: zswap: fix global shrinker error handling logic:
- Change error code for no-writeback memcg. (Yosry)
- Use nr_scanned to check if lru is empty. (Yosry)

Changes in v1:
mm: zswap: fix global shrinker memcg iteration:
- Drop and reacquire spinlock before skipping a memcg.
- Add some comment to clarify the locking mechanism.

---

Takero Funaki (2):
mm: zswap: fix global shrinker memcg iteration
mm: zswap: fix global shrinker error handling logic

 mm/zswap.c | 106 ++++++++++++++++++++++++++++++++++++++---------------
 1 file changed, 76 insertions(+), 30 deletions(-)
Signature · 1 line
2.43.0