Skip to content

varargs functions with __attributes__(())

Junio C Hamano git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4__attribute__: trace2_region_enter_printf() is like "printf"run-command.c trace2.h+3 -12 replies
2/4__attribute__: remove redundant attribute declaration for git_die_config()config.c+0 -10 replies
3/4__attribute__: mark some functions with LAST_ARG_MUST_BE_NULLadd-patch.c attr.h hook.h +1 more+5 -00 replies
4/4__attribute__: add a few missing format attributesmem-pool.h scalar.c wt-status.c+3 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] varargs functions with __attributes__(())

There are several varargs functions that take either NULL-terminated list of parameters, or printf-like format followed by list of parameters, that are not declared as such with __attributes__(()).

Adding such a missing attribute to trace2_region_enter_printf() revealed that an existing call to it was trying to format a value of type size_t using "%d", which is not such an excellent idea. Other functions that were lacking attributes fortunately did not have any broken existing callers.

Junio C Hamano (4):
__attribute__: trace2_region_enter_printf() is like "printf" __attribute__: remove redundant __attribute__ declaration for
git_die_config()
__attribute__: mark some functions with LAST_ARG_MUST_BE_NULL __attribute__: add a few missing format attributes

 add-patch.c   | 1 +
 attr.h        | 2 ++
 config.c      | 1 -
 hook.h        | 1 +
 mem-pool.h    | 1 +
 run-command.c | 3 ++-
 scalar.c      | 2 ++
 trace2.h      | 1 +
 wt-status.c   | 1 +
 9 files changed, 11 insertions(+), 2 deletions(-)
Signature · 1 line
2.45.2-445-g1b76f06508