Skip to content

net: flower: validate encapsulation control flags

Asbjørn Sloth Tønnesen intel-wired-lan linux-rdma lkml netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 6 repliesApplied 5/5

Patches in v1 All 5 applied

#Subject and filesSizeRepliesApplied
1/5flow_offload: add encapsulation control flag helpersinclude/net/flow_offload.h+35 -00 repliesApplied
2/5sfc: use flow_rule_is_supp_enc_control_flags()drivers/net/ethernet/sfc/tc.c+1 -41 replyApplied
3/5net/mlx5e: flower: validate encapsulation control flagsdrivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c+6 -00 repliesApplied
4/5nfp: flower: validate encapsulation control flagsdrivers/net/ethernet/netronome/nfp/flower/offload.c+4 -01 replyApplied
5/5ice: flower: validate encapsulation control flagsdrivers/net/ethernet/intel/ice/ice_tc_lib.c+4 -01 replyApplied

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMarcin SzycikEdward CreeDavide Caratti
SeriesR-b
1/5
2/5A-b
3/5
4/5
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH net-next 0/5] net: flower: validate encapsulation control flags

Now that all drivers properly rejects unsupported flower control flags used with FLOW_DISSECTOR_KEY_CONTROL, then time has come to add similar checks to the drivers supporting FLOW_DISSECTOR_KEY_ENC_CONTROL.

There are currently just 4 drivers supporting this key, and 3 of those currently doesn't validate encapsulated control flags.

Encapsulation control flags may currently be unused, but they should still be validated by the drivers, so that drivers will properly reject any new flags when they are introduced.

This series adds some helper functions, and implements them in all 4 drivers.

NB: It is currently discussed[1] to use encapsulation control flags for tunnel flags instead of the new FLOW_DISSECTOR_KEY_ENC_FLAGS.

[1] https://lore.kernel.org/netdev/[email protected]/

Asbjørn Sloth Tønnesen (5):
flow_offload: add encapsulation control flag helpers
sfc: use flow_rule_is_supp_enc_control_flags() net/mlx5e: flower: validate encapsulation control flags
nfp: flower: validate encapsulation control flags
ice: flower: validate encapsulation control flags

 drivers/net/ethernet/intel/ice/ice_tc_lib.c   |  4 +++
 .../ethernet/mellanox/mlx5/core/en/tc_tun.c   |  6 ++++
 .../ethernet/netronome/nfp/flower/offload.c   |  4 +++
 drivers/net/ethernet/sfc/tc.c                 |  5 +--
 include/net/flow_offload.h                    | 35 +++++++++++++++++++
 5 files changed, 50 insertions(+), 4 deletions(-)
Signature · 1 line
2.45.1