Skip to content

hw/ppc: Prefer HumanReadableText over Monitor

Philippe Mathieu-Daudé qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest26 patches 20 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/26hw/ppc: Avoid using Monitor in pnv_phb3_msi_pic_print_info()hw/pci-host/pnv_phb3_msi.c hw/ppc/pnv.c include/hw/pci-host/pnv_phb3.h+18 -133 replies
2/26hw/ppc: Avoid using Monitor in icp_pic_print_info()hw/intc/xics.c hw/intc/xics_spapr.c hw/ppc/pnv.c +1 more+19 -70 replies
3/26hw/ppc: Avoid using Monitor in xive_tctx_pic_print_info()hw/intc/spapr_xive.c hw/intc/xive.c hw/ppc/pnv.c +1 more+27 -92 replies
4/26hw/ppc: Avoid using Monitor in ics_pic_print_info()hw/intc/xics.c hw/intc/xics_spapr.c hw/ppc/pnv.c +1 more+19 -190 replies
5/26hw/ppc: Avoid using Monitor in PnvChipClass::intc_print_info()hw/ppc/pnv.c include/hw/ppc/pnv_chip.h+9 -230 replies
6/26hw/ppc: Avoid using Monitor in xive_end_queue_pic_print_info()hw/intc/spapr_xive.c hw/intc/xive.c include/hw/ppc/xive_regs.h+18 -81 reply
7/26hw/ppc: Avoid using Monitor in spapr_xive_end_pic_print_info()hw/intc/spapr_xive.c+10 -101 reply
8/26hw/ppc: Avoid using Monitor in spapr_xive_pic_print_info()hw/intc/spapr_xive.c+12 -161 reply
9/26hw/ppc: Avoid using Monitor in xive_source_pic_print_info()hw/intc/pnv_xive.c hw/intc/pnv_xive2.c hw/intc/xive.c +3 more+46 -230 replies
10/26hw/ppc: Avoid using Monitor in pnv_phb4_pic_print_info()hw/pci-host/pnv_phb4.c hw/ppc/pnv.c include/hw/pci-host/pnv_phb4.h+7 -100 replies
11/26hw/ppc: Avoid using Monitor in xive_eas_pic_print_info()hw/intc/pnv_xive.c hw/intc/xive.c include/hw/ppc/xive_regs.h+12 -120 replies
12/26hw/ppc: Avoid using Monitor in xive_end_pic_print_info()hw/intc/pnv_xive.c hw/intc/xive.c include/hw/ppc/xive_regs.h+23 -270 replies
13/26hw/ppc: Avoid using Monitor in xive_end_eas_pic_print_info()hw/intc/pnv_xive.c hw/intc/xive.c include/hw/ppc/xive_regs.h+16 -170 replies
14/26hw/ppc: Avoid using Monitor in xive_nvt_pic_print_info()hw/intc/pnv_xive.c+10 -90 replies
15/26hw/ppc: Avoid using Monitor in pnv_xive_pic_print_info()hw/intc/pnv_xive.c hw/ppc/pnv.c include/hw/ppc/pnv_xive.h+9 -100 replies
16/26hw/ppc: Avoid using Monitor in pnv_psi_pic_print_info()hw/ppc/pnv.c hw/ppc/pnv_psi.c include/hw/ppc/pnv_psi.h+9 -120 replies
17/26hw/ppc: Avoid using Monitor in xive2_eas_pic_print_info()hw/intc/pnv_xive2.c hw/intc/xive2.c include/hw/ppc/xive2_regs.h+15 -150 replies
18/26hw/ppc: Avoid using Monitor in xive2_end_eas_pic_print_info()hw/intc/pnv_xive2.c hw/intc/xive2.c include/hw/ppc/xive2_regs.h+16 -160 replies
19/26hw/ppc: Avoid using Monitor in xive2_end_queue_pic_print_info()hw/intc/xive2.c include/hw/ppc/xive2_regs.h+13 -80 replies
20/26hw/ppc: Avoid using Monitor in xive2_end_pic_print_info()hw/intc/pnv_xive2.c hw/intc/xive2.c include/hw/ppc/xive2_regs.h+26 -320 replies
21/26hw/ppc: Avoid using Monitor in xive2_nvp_pic_print_info()hw/intc/pnv_xive2.c+15 -140 replies
22/26hw/ppc: Avoid using Monitor in pnv_xive2_pic_print_info()hw/intc/pnv_xive2.c hw/ppc/pnv.c include/hw/ppc/pnv_xive.h+3 -100 replies
23/26hw/ppc: Avoid using Monitor in SpaprInterruptControllerClass::print_info()hw/intc/spapr_xive.c hw/intc/xics_spapr.c hw/ppc/spapr_irq.c +1 more+10 -180 replies
24/26hw/ppc: Avoid using Monitor in spapr_irq_print_info()hw/ppc/spapr.c hw/ppc/spapr_irq.c include/hw/ppc/spapr_irq.h+10 -110 replies
25/26hw/ppc: Avoid using Monitor in pnv_chip_power9_pic_print_info_child()hw/ppc/pnv.c+6 -120 replies
26/26hw/ppc: Avoid using Monitor in pic_print_info()hw/ppc/pnv.c include/hw/ppc/pnv_chip.h+8 -230 replies

Reviews trailers per patch

1 of 26 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchManos PitsidianakisCédric Le GoaterHarsh Prateek Bora
SeriesR-b R-b R-b
1/26R-b
2/26
3/26
4/26
5/26
6/26
7/26
8/26
9/26
10/26
11/26
12/26
13/26
14/26
15/26
16/26
17/26
18/26
19/26
20/26
21/26
22/26
23/26
24/26
25/26
26/26

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/26] hw/ppc: Prefer HumanReadableText over Monitor

Hi,

This series remove uses of Monitor in hw/ppc/, replacing by the more generic HumanReadableText. Care is taken to keep the commit bisectables by updating functions one by one, also easing review.

For rationale see previous series from Daniel:
https://lore.kernel.org/qemu-devel/[email protected]/

Regards,

Phil.

Philippe Mathieu-Daudé (26):
hw/ppc: Avoid using Monitor in pnv_phb3_msi_pic_print_info() hw/ppc: Avoid using Monitor in icp_pic_print_info() hw/ppc: Avoid using Monitor in xive_tctx_pic_print_info() hw/ppc: Avoid using Monitor in ics_pic_print_info() hw/ppc: Avoid using Monitor in PnvChipClass::intc_print_info() hw/ppc: Avoid using Monitor in xive_end_queue_pic_print_info() hw/ppc: Avoid using Monitor in spapr_xive_end_pic_print_info() hw/ppc: Avoid using Monitor in spapr_xive_pic_print_info() hw/ppc: Avoid using Monitor in xive_source_pic_print_info() hw/ppc: Avoid using Monitor in pnv_phb4_pic_print_info() hw/ppc: Avoid using Monitor in xive_eas_pic_print_info() hw/ppc: Avoid using Monitor in xive_end_pic_print_info() hw/ppc: Avoid using Monitor in xive_end_eas_pic_print_info() hw/ppc: Avoid using Monitor in xive_nvt_pic_print_info() hw/ppc: Avoid using Monitor in pnv_xive_pic_print_info() hw/ppc: Avoid using Monitor in pnv_psi_pic_print_info() hw/ppc: Avoid using Monitor in xive2_eas_pic_print_info() hw/ppc: Avoid using Monitor in xive2_end_eas_pic_print_info() hw/ppc: Avoid using Monitor in xive2_end_queue_pic_print_info() hw/ppc: Avoid using Monitor in xive2_end_pic_print_info() hw/ppc: Avoid using Monitor in xive2_nvp_pic_print_info() hw/ppc: Avoid using Monitor in pnv_xive2_pic_print_info() hw/ppc: Avoid using Monitor in
SpaprInterruptControllerClass::print_info()
hw/ppc: Avoid using Monitor in spapr_irq_print_info() hw/ppc: Avoid using Monitor in pnv_chip_power9_pic_print_info_child() hw/ppc: Avoid using Monitor in pic_print_info()

 include/hw/pci-host/pnv_phb3.h |   2 +-
 include/hw/pci-host/pnv_phb4.h |   2 +-
 include/hw/ppc/pnv_chip.h      |   4 +-
 include/hw/ppc/pnv_psi.h       |   2 +-
 include/hw/ppc/pnv_xive.h      |   4 +-
 include/hw/ppc/spapr_irq.h     |   4 +-
 include/hw/ppc/xics.h          |   4 +-
 include/hw/ppc/xive.h          |   4 +-
 include/hw/ppc/xive2_regs.h    |   8 +--
 include/hw/ppc/xive_regs.h     |   8 +--
 hw/intc/pnv_xive.c             |  38 ++++++------
 hw/intc/pnv_xive2.c            |  48 +++++++--------
 hw/intc/spapr_xive.c           |  41 ++++++-------
 hw/intc/xics.c                 |  25 ++++----
 hw/intc/xics_spapr.c           |   7 +--
 hw/intc/xive.c                 | 108 ++++++++++++++++-----------------
 hw/intc/xive2.c                |  87 +++++++++++++-------------
 hw/pci-host/pnv_phb3_msi.c     |  21 +++----
 hw/pci-host/pnv_phb4.c         |  17 +++---
 hw/ppc/pnv.c                   |  52 ++++++++--------
 hw/ppc/pnv_psi.c               |   9 ++-
 hw/ppc/spapr.c                 |  11 +++-
 hw/ppc/spapr_irq.c             |   4 +-
 23 files changed, 256 insertions(+), 254 deletions(-)
Signature · 1 line
2.41.0