bnxt_en: implement netdev_queue_mgmt_ops
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest2 patches 6 repliesApplied 2/2
- v23 patches 0 repliesSuperseded
- v13 patches 9 repliesSuperseded
Changes in v3 from the cover letter
- tested w/o bnxt_hwrm_vnic_update() and it works on any queue
- removed unneeded code
Patches in v3 All 2 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | bnxt_en: split rx ring helpers out from ring helpersdrivers/ | +193 | 1 reply | Applied |
| 2/2 | bnxt_en: implement netdev_queue_mgmt_opsdrivers/ | +275 | 5 replies | Applied |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Somnath Kotur | Simon Horman |
|---|---|---|
| 1/2 | R-b | |
| 2/2 | A-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v3 0/2] bnxt_en: implement netdev_queue_mgmt_ops
Implement netdev_queue_mgmt_ops for bnxt added in [1]. This will be used in the io_uring ZC Rx patchset to configure queues with a custom page pool w/ a special memory provider for zero copy support.
The first two patches prep the driver, while the final patch adds the implementation.
Any arbitrary Rx queue can be reset without affecting other queues. V2 and prior of this patchset was thought to only support resetting queues not in the main RSS context. Upon further testing I realised moving queues out and calling bnxt_hwrm_vnic_update() wasn't necessary.
I didn't include the netdev core API using this netdev_queue_mgmt_ops because Mina is adding it in his devmem TCP series [2]. But I'm happy to include it if folks want to include a user with this series.
I tested this series on BCM957504-N1100FY4 with FW 229.1.123.0. I manually injected failures at all the places that can return an errno and confirmed that the device/queue is never left in a broken state.
[1]: https://lore.kernel.org/netdev/[email protected]/
[2]: https://lore.kernel.org/netdev/[email protected]/
---
v3:
- tested w/o bnxt_hwrm_vnic_update() and it works on any queue
- removed unneeded code
v2:
- fix broken build
- remove unused var in bnxt_init_one_rx_ring()
David Wei (2):
bnxt_en: split rx ring helpers out from ring helpers
bnxt_en: implement netdev_queue_mgmt_ops
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 575 ++++++++++++++++++---- 1 file changed, 468 insertions(+), 107 deletions(-)
Signature · 1 line
2.43.0