Skip to content

backlight: Introduce power-state constants

Thomas Zimmermann dri-devel linux-fbdev linux-pwm 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest17 patches 4 repliesApplied
  2. v117 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- rename BL_CORE_ power constants to BACKLIGHT_POWER_ (Sam)
- fix documentation

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/17backlight: Add BACKLIGHT_POWER_ constants for power statesDocumentation/ABI/stable/sysfs-class-backlight include/linux/backlight.h+16 -110 replies
2/17backlight: aat2870-backlight: Use blacklight power constantsdrivers/video/backlight/aat2870_bl.c+2 -20 replies
3/17backlight: ams369fb06: Use backlight power constantsdrivers/video/backlight/ams369fg06.c+11 -120 replies
4/17backlight: corgi-lcd: Use backlight power constantsdrivers/video/backlight/corgi_lcd.c+2 -20 replies
5/17backlight: gpio-backlight: Use backlight power constantsdrivers/video/backlight/gpio_backlight.c+4 -51 reply
6/17backlight: ipaq-micro-backlight: Use backlight power constantsdrivers/video/backlight/ipaq_micro_bl.c+1 -21 reply
7/17backlight: journada_bl: Use backlight power constantsdrivers/video/backlight/jornada720_bl.c+1 -20 replies
8/17backlight: kb3886-bl: Use backlight power constantsdrivers/video/backlight/kb3886_bl.c+2 -20 replies
9/17backlight: ktd253-backlight: Use backlight power constantsdrivers/video/backlight/ktd253-backlight.c+2 -30 replies
10/17backlight: led-backlight: Use backlight power constantsdrivers/video/backlight/led_bl.c+2 -20 replies
11/17backlight: lm3533-backlight: Use backlight power constantsdrivers/video/backlight/lm3533_bl.c+1 -20 replies
12/17backlight: mp3309c: Use backlight power constantsdrivers/video/backlight/mp3309c.c+2 -20 replies
13/17backlight: pandora-backlight: Use backlight power constantsdrivers/video/backlight/pandora_bl.c+1 -20 replies
14/17backlight: pcf50633-backlight: Use backlight power constantsdrivers/video/backlight/pcf50633-backlight.c+2 -30 replies
15/17backlight: pwm-backlight: Use backlight power constantsdrivers/video/backlight/pwm_bl.c+2 -20 replies
16/17backlight: rave-sp-backlight: Use backlight power constantsdrivers/video/backlight/rave-sp-backlight.c+1 -10 replies
17/17backlight: sky81452-backlight: Use backlight power constantsdrivers/video/backlight/sky81452-backlight.c+1 -10 replies

Reviews trailers per patch

2 of 17 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLinus WalleijDaniel Thompson
SeriesR-b
1/17
2/17
3/17
4/17
5/17R-b
6/17R-b
7/17
8/17
9/17
10/17
11/17
12/17
13/17
14/17
15/17
16/17
17/17

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/17] backlight: Introduce power-state constants

The backlight code currently uses fbdev's FB_BLANK_ constants to represent power states UNBLANK and POWERDOWN. Introduce dedicated backlight constants to remove this dependency on fbdev.

Patch 1 introduces BACKLIGHT_POWER_ON and BACKLIGHT_POWER_OFF, which replace constants from fbdev. There's also BACKLIGHT_POWER_REDUCED, which is required by a few drivers that appear to use incorrect or uncommon blanking semantics.

The rest of the patchset converts backlight drivers. The new constants' values are identical to the old ones, so the driver conversion can be done one-by-one.

There are many more backlight drivers in other subsystems. These can later be converted when the new constants have been merged. Once merged, several include statements for <linux/fb.h> can be removed (specifically under drivers/platform/x86/).

This patchset is part of a larger effort to implement the backlight code without depending on fbdev and ultimatively remove fbdev dependencies from the kernel.

v2:
- rename BL_CORE_ power constants to BACKLIGHT_POWER_ (Sam)
- fix documentation

Thomas Zimmermann (17):
backlight: Add BACKLIGHT_POWER_ constants for power states
backlight: aat2870-backlight: Use blacklight power constants
backlight: ams369fb06: Use backlight power constants
backlight: corgi-lcd: Use backlight power constants
backlight: gpio-backlight: Use backlight power constants
backlight: ipaq-micro-backlight: Use backlight power constants
backlight: journada_bl: Use backlight power constants
backlight: kb3886-bl: Use backlight power constants
backlight: ktd253-backlight: Use backlight power constants
backlight: led-backlight: Use backlight power constants
backlight: lm3533-backlight: Use backlight power constants
backlight: mp3309c: Use backlight power constants
backlight: pandora-backlight: Use backlight power constants
backlight: pcf50633-backlight: Use backlight power constants
backlight: pwm-backlight: Use backlight power constants
backlight: rave-sp-backlight: Use backlight power constants
backlight: sky81452-backlight: Use backlight power constants

 .../ABI/stable/sysfs-class-backlight          |  7 +++---
 drivers/video/backlight/aat2870_bl.c          |  4 ++--
 drivers/video/backlight/ams369fg06.c          | 23 +++++++++----------
 drivers/video/backlight/corgi_lcd.c           |  4 ++--
 drivers/video/backlight/gpio_backlight.c      |  9 ++++----
 drivers/video/backlight/ipaq_micro_bl.c       |  3 +--
 drivers/video/backlight/jornada720_bl.c       |  3 +--
 drivers/video/backlight/kb3886_bl.c           |  4 ++--
 drivers/video/backlight/ktd253-backlight.c    |  5 ++--
 drivers/video/backlight/led_bl.c              |  4 ++--
 drivers/video/backlight/lm3533_bl.c           |  3 +--
 drivers/video/backlight/mp3309c.c             |  4 ++--
 drivers/video/backlight/pandora_bl.c          |  3 +--
 drivers/video/backlight/pcf50633-backlight.c  |  5 ++--
 drivers/video/backlight/pwm_bl.c              |  4 ++--
 drivers/video/backlight/rave-sp-backlight.c   |  2 +-
 drivers/video/backlight/sky81452-backlight.c  |  2 +-
 include/linux/backlight.h                     | 20 +++++++++-------
 18 files changed, 53 insertions(+), 56 deletions(-)
Signature · 1 line
2.45.2