Skip to content

: nvme-fc: fix race with connectivity loss with nvme_fc_create_association

Daniel Wagner linux-nvme 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2nvme-fc: go straight to connecting state when initializingdrivers/nvme/host/fc.c+1 -22 replies
2/2nvme-fc: fix race with connectivity loss with nvme_fc_create_associationdrivers/nvme/host/fc.c+21 -34 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchSagi GrimbergHannes ReineckePaul Ely
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH v1 0/2]: nvme-fc: fix race with connectivity loss with nvme_fc_create_association

We got a bug report that a controller was stuck in the connected state after an association dropped. It turns out that nvme_fc_create_association can succeed even though some operation do fail. This is on purpose to handle other corner cases, thus we can't really make nvme_fc_create_assocication bullet proof.

Given this, I think the second best option is to ensure that we always schedule a reset whenever a connectivity loss is observed in CONNECTING state. This is not perfect (possible back to back reset) but at least it is correct, which wins in my books.

Daniel Wagner (2):
nvme-fc: go straight to connecting state when initializing
nvme-fc: fix race with connectivity loss with
nvme_fc_create_association

 drivers/nvme/host/fc.c | 27 ++++++++++++++++++++++-----
 1 file changed, 22 insertions(+), 5 deletions(-)
Signature · 1 line
2.45.2