Skip to content

RFC mmc-spi - support controllers incapable of getting as low as 400KHz

Conor Dooley linux-mmc linux-riscv linux-spi lkml 1 version In review

Get series with b4
b4 am 20240612-brigade-shell-1f626e7e592f@spud

Versions newest first

  1. v1 RFC Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3mmc: mmc_spi: allow for spi controllers incapable of getting as low as 400kdrivers/mmc/host/mmc_spi.c+4 -13 replies
2/3spi: microchip-core-qspi: Add regular transfersdrivers/spi/spi-microchip-core-qspi.c+221 -23 replies
3/3spi: microchip-core-qspi: set min_speed_hz during probedrivers/spi/spi-microchip-core-qspi.c+1 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC v1 0/3] mmc-spi - support controllers incapable of getting as low as 400KHz

From: Conor Dooley <[email protected]>

Yo,

RFC for some stuff that I've got in-progress for a customer's board where they want to use mmc-spi-slot with a QSPI controller that is incapable of getting as low as 400KHz with the way clocks have been configured on the system. At the moment, if a controller cannot get that low, linux continuously reports that queuing a transfer fails. The first couple of transfers will complete on this system, until mmc_start_host() kicks in and clamps the frequency to the larger of host->f_min and 400 KHz.
Doing something like patch 1 of this set would allow the mmc-spi-slot to function for some sd cards, an improvement on the current none. I don't have any sd cards on hand that don't support the 5 MHz minimum frequency that this controller is limited to, so I amn't sure at what point this will blow up if such a card was used.

Is this sort of change something that would fly?

Patches 2 & 3 are just here b/c without #3 the qspi driver for this platform doesn't support anything other than mem ops and #2 is required to set the minimum frequency for mmc_spi to pick up.

Cheers,
Conor.

Conor Dooley (2):
mmc: mmc_spi: allow for spi controllers incapable of getting as low as

    400k

spi: microchip-core-qspi: set min_speed_hz during probe

Cyril Jean (1):
spi: microchip-core-qspi: Add regular transfers

 drivers/mmc/host/mmc_spi.c            |   5 +-
 drivers/spi/spi-microchip-core-qspi.c | 224 +++++++++++++++++++++++++-
 2 files changed, 226 insertions(+), 3 deletions(-)
Signature · 1 line
2.43.0