Skip to content

Add support for Imagis IST3038 and clarify the usage of protocol_b

Raymond Hackley linux-devicetree linux-input lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v13 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3input/touchscreen: imagis: Clarify the usage of protocol_bdrivers/input/touchscreen/imagis.c+5 -40 replies
2/3dt-bindings: input/touchscreen: imagis: Document ist3038Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml+1 -01 reply
3/3input/touchscreen: imagis: Add supports for Imagis IST3038drivers/input/touchscreen/imagis.c+20 -40 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchKrzysztof Kozlowski
1/3
2/3A-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] Add support for Imagis IST3038 and clarify the usage of protocol_b

Imagis IST3038 is another variant of Imagis IST3038 IC, which has a different register interface from IST3038C (possibly firmware defined).

Unlike IST3038C/IST3032C, IST3038 has different registers for commands, which means IST3038 doesn't use protocol B.
Similar to IST3032C and maybe the other variants, IST3038 has touch keys support, which provides KEY_APPSELECT and KEY_BACK.

Add support for IST3038 with touch keys.

protocol_b is a property, which tells Imagis panel to use a different format for coordinates.

IST30XXC series is known for using protocol B, while the other series aren't. Note this could be confusing, unlike the model name implies.

Adjust the usage of protocol_b to avoid confusion.

---
v2: Sort the compatible enties in alphabetical order.
Document the binding before using in the driver.