Skip to content

migration: New postcopy state, and some cleanups

Peter Xu qemu-devel 3 versions – Applied

Status from this message: Queued, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest11 patches 4 repliesApplied
  2. v210 patches 13 repliesSuperseded
  3. v14 patches 12 repliesSuperseded

Changes in v3 from the cover letter

- Added one comment in patch 8 explaining why migrate_incoming_qmp() needs to keep enabling "events" capability.
- Split patch 9 into two patches, which makes migration_event_wait() to be used also in migrate_incoming_qmp()
- Rename the tests in last patch, and a spell fix
- Rebased to "[PATCH v3 00/16] migration/mapped-ram: Add direct-io support"

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/11migration/multifd: Avoid the final FLUSH in complete()migration/ram.c+0 -40 replies
2/11migration: Rename thread debug namesmigration/colo.c migration/migration.c migration/multifd.c +2 more+10 -100 replies
3/11migration: Use MigrationStatus instead of intmigration/migration.c migration/migration.h+12 -210 replies
4/11migration: Cleanup incoming migration setup state changemigration/migration.c+26 -20 replies
5/11migration/postcopy: Add postcopy-recover-setup phasemigration/migration.c migration/postcopy-ram.c migration/postcopy-ram.h +2 more+49 -80 replies
6/11migration/docs: Update postcopy recover session for SETUP phasedocs/devel/migration/postcopy.rst+16 -150 replies
7/11tests/migration-tests: Drop most WIN32 ifdefs for postcopy failure teststests/qtest/migration-test.c+2 -80 replies
8/11tests/migration-tests: Always enable migration eventstests/qtest/migration-helpers.c tests/qtest/migration-test.c+8 -01 reply
9/11tests/migration-tests: migration_event_wait()tests/qtest/migration-helpers.c tests/qtest/migration-helpers.h+24 -91 reply
10/11tests/migration-tests: Verify postcopy-recover-setup statustests/qtest/migration-test.c+6 -01 reply
11/11tests/migration-tests: Cover postcopy failure on reconnecttests/qtest/migration-test.c+77 -180 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchFabiano RosasZhijian Li (Fujitsu)
1/11R-b T-b
2/11R-b R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/11] migration: New postcopy state, and some cleanups

Based-on: <[email protected]>

v3:
- Added one comment in patch 8 explaining why migrate_incoming_qmp() needs to keep enabling "events" capability.
- Split patch 9 into two patches, which makes migration_event_wait() to be used also in migrate_incoming_qmp()
- Rename the tests in last patch, and a spell fix
- Rebased to "[PATCH v3 00/16] migration/mapped-ram: Add direct-io support"

v1: https://lore.kernel.org/r/[email protected]
v2: https://lore.kernel.org/r/[email protected]

The major goal of this patchset is patch 5, which introduced a new postcopy state so that we will send an event in postcopy reconnect failures that Libvirt would prefer to have. There's more information for that issue in the commit message alone.

Patch 1-2 are cleanups that are not directly relevant but I found/stored that could be good to have. I made it simple by putting them together in one thread to make patch management easier, but I can send them separately when necessary.

Patch 3 is also a cleanup, but will be needed for patch 4 as dependency.

Patch 4-5 is the core patches.

Patch 6 updates doc for the new state.

Patch 7-11 adds a new test for the new state.

CI: https://gitlab.com/peterx/qemu/-/pipelines/1339544694

Comments welcomed, thanks.

Peter Xu (11):
migration/multifd: Avoid the final FLUSH in complete()
migration: Rename thread debug names
migration: Use MigrationStatus instead of int
migration: Cleanup incoming migration setup state change migration/postcopy: Add postcopy-recover-setup phase migration/docs: Update postcopy recover session for SETUP phase tests/migration-tests: Drop most WIN32 ifdefs for postcopy failure
tests
tests/migration-tests: Always enable migration events tests/migration-tests: migration_event_wait() tests/migration-tests: Verify postcopy-recover-setup status tests/migration-tests: Cover postcopy failure on reconnect

 docs/devel/migration/postcopy.rst |  31 ++++----
 qapi/migration.json               |   4 ++
 migration/migration.h             |   9 +--
 migration/postcopy-ram.h          |   3 +
 tests/qtest/migration-helpers.h   |   2 +
 migration/colo.c                  |   2 +-
 migration/migration.c             |  98 +++++++++++++++++--------
 migration/multifd.c               |   6 +-
 migration/postcopy-ram.c          |  10 ++-
 migration/ram.c                   |   4 --
 migration/savevm.c                |   6 +-
 tests/qtest/migration-helpers.c   |  32 ++++++---
 tests/qtest/migration-test.c      | 116 +++++++++++++++++++++++-------
 13 files changed, 229 insertions(+), 94 deletions(-)
Signature · 1 line
2.45.0