Skip to content

nfs: Improve throughput for random buffered writes

Jan Kara linux-nfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 5 repliesIn review
  2. v13 patches 10 repliesSuperseded

Changes in v2 from the cover letter

* Added Reviewed-by tags
* Made sleep waiting for congestion to resolve killable

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3nfs: Drop pointless check from nfs_commit_release_pages()fs/nfs/write.c+0 -40 replies
2/3nfs: Properly initialize server->writebackfs/nfs/client.c+2 -01 reply
3/3nfs: Block on write congestionfs/nfs/client.c fs/nfs/write.c include/linux/nfs_fs_sb.h+13 -40 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchSagi GrimbergJeff Layton
1/3R-b R-b
2/3R-b A-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH RESEND v2 0/3] nfs: Improve throughput for random buffered writes

[Resending because of messed up mailing list address]

Hello,

this is second revision of my patch series improving NFS throughput for buffered writes.

Changes since v1:
* Added Reviewed-by tags
* Made sleep waiting for congestion to resolve killable

Original cover letter below:

I was thinking how to best address the performance regression coming from NFS write congestion. After considering various options and concerns raised in the previous discussion, I've got an idea for a simple option that could help to keep the server more busy - just mimick what block devices do and block the flush worker waiting for congestion to resolve instead of aborting the writeback. And it actually helps enough that I don't think more complex solutions are warranted at this point.

This patch series has two preparatory cleanups and then a patch implementing this idea.

Honza

Previous versions: