Skip to content

Do not read the IO hints VPD page from USB storage devices

Bart Van Assche linux-scsi linux-usb stable 3 versions – Applied

Status from this message: Applied to 6.10/scsi-fixes, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyApplied
  2. v22 patches 4 repliesSuperseded
  3. v12 patches 6 repliesSuperseded

Changes in v3 from the cover letter

- Changed "IO hints VPD page" into "IO Advice Hints Grouping mode page".
- Changed "scsi: core: " prefix for patch 2/2 into "usb: ".
- Removed redundant Cc-tags.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/2scsi: core: Introduce the BLIST_SKIP_IO_HINTS flagdrivers/scsi/sd.c include/scsi/scsi_devinfo.h+7 -10 replies
2/2usb: Do not query the IO advice hints grouping mode page for USB devicesdrivers/usb/storage/scsiglue.c drivers/usb/storage/uas.c+13 -00 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchAlan SternAndy ShevchenkoChristian Heusel
1/2
2/2A-b T-b Bisected-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/2] Do not read the IO hints VPD page from USB storage devices

Hi Martin,

Recently it was reported that reading the IO hints VPD page makes at least two USB storage devices crash. Hence this patch series that disables reading the IO hints VPD page from USB storage devices. Please consider this patch series for your scsi-fixes branch.

Thanks,

Bart.

Changes compared to v2:
- Changed "IO hints VPD page" into "IO Advice Hints Grouping mode page".
- Changed "scsi: core: " prefix for patch 2/2 into "usb: ".
- Removed redundant Cc-tags.

Changes compared to v1:
- Also set the BLIST_SKIP_IO_HINTS for USB Attached SCSI devices.

Bart Van Assche (2):
scsi: core: Introduce the BLIST_SKIP_IO_HINTS flag
usb: Do not query the IO advice hints grouping mode page for USB
devices

 drivers/scsi/sd.c              | 4 ++++
 drivers/usb/storage/scsiglue.c | 6 ++++++
 drivers/usb/storage/uas.c      | 7 +++++++
 include/scsi/scsi_devinfo.h    | 4 +++-
 4 files changed, 20 insertions(+), 1 deletion(-)