Skip to content

pcie hotplug and error fixes

Keith Busch linux-pci 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 7 repliesIn review
  2. v12 patches 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2PCI: pciehp: fix concurrent sub-tree removal deadlockdrivers/pci/hotplug/pciehp_pci.c drivers/pci/pci.h drivers/pci/probe.c +1 more+38 -35 replies
2/2PCI: err: ensure stable topology during handlingdrivers/pci/pcie/err.c+7 -12 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchKeith Busch
1/2
2/2R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCHv2 0/2] pcie hotplug and error fixes

From: Keith Busch <[email protected]>

We' failures when dealing with certain overlapping pcie events. The topology is essentially this:

[Root Port] <-> [UpStream Port] <-> [DownStream Port] <-> [End Device]

An error between the DSP and ED triggers DPC. There's only inband presence detection so it also triggers hotplug. Before the error handling is completed, though, another error seen by the RP triggers its own DPC handling.

The concurrent event handling reveals some interesting races, and this patchset tries to address these without fundamentally changing the locking scheme.

v1->v2:

Fixed compiler error for !CONFIG_PCI (lkp)

Keith Busch (2):
PCI: pciehp: fix concurrent sub-tree removal deadlock
PCI: err: ensure stable topology during handling

 drivers/pci/hotplug/pciehp_pci.c | 12 +++++++++---
 drivers/pci/pci.h                |  1 +
 drivers/pci/pcie/err.c           |  8 +++++++-
 drivers/pci/probe.c              | 24 ++++++++++++++++++++++++
 include/linux/pci.h              |  2 ++
 5 files changed, 43 insertions(+), 4 deletions(-)
Signature · 1 line
2.43.0