Skip to content

netfilter: xt_recent: Allow for larger hitcount values

Phil Sutter netfilter-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 6 repliesIn review
  2. v12 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- Do not support insanely large hitcount values to limit the amount of storage allocated per entry
- Fix typo in subject of patch 1

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2netfilter: xt_recent: Reduce size of struct recent_entry::nstampsnet/netfilter/xt_recent.c+1 -14 replies
2/2netfilter: xt_recent: Lift restrictions on max hitcount valuenet/netfilter/xt_recent.c+5 -52 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchFabio
1/2
2/2Requested-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [nf-next PATCH v2 0/2] netfilter: xt_recent: Allow for larger hitcount values

Changes since v1:
- Do not support insanely large hitcount values to limit the amount of storage allocated per entry
- Fix typo in subject of patch 1

Patch 2 lifts the restriction of 255 as max hitcount value by adjusting XT_RECENT_MAX_NSTAMPS value and increasing required struct field sizes accordingly.

In struct recent_entry, field 'nstamps' was 16bit in size of unclear reasons. Patch 1 changes that to match field 'index' providing rationale why it is sufficient, thus paving the way for keeping both at 16bit (and avoiding a larger size for 'nstamps').

Phil Sutter (2):
netfilter: xt_recent: Reduce size of struct recent_entry::nstamps
netfilter: xt_recent: Lift restrictions on max hitcount value

 net/netfilter/xt_recent.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
2.43.0