Skip to content

ublk: support device recovery without I/O queueing

Uday Shankar linux-block linux-doc 4 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 3 repliesApplied
  2. v35 patches 2 repliesSuperseded
  3. v24 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches14 repliesSuperseded

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/5ublk: check recovery flags for validitydrivers/block/ublk_drv.c+11 -00 replies
2/5ublk: refactor recovery configuration flag helpersdrivers/block/ublk_drv.c+42 -200 replies
3/5ublk: merge stop_work and quiesce_workdrivers/block/ublk_drv.c+25 -390 replies
4/5ublk: support device recovery without I/O queueingdrivers/block/ublk_drv.c include/uapi/linux/ublk_cmd.h+81 -151 reply
5/5Documentation: ublk: document UBLK_F_USER_RECOVERY_FAIL_IODocumentation/block/ublk.rst+18 -61 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchMing Lei
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/5] ublk: support device recovery without I/O queueing

ublk currently supports the following behaviors on ublk server exit:

A: outstanding I/Os get errors, subsequently issued I/Os get errors
B: outstanding I/Os get errors, subsequently issued I/Os queue
C: outstanding I/Os get reissued, subsequently issued I/Os queue

and the following behaviors for recovery of preexisting block devices by a future incarnation of the ublk server:

1: ublk devices stopped on ublk server exit (no recovery possible) 2: ublk devices are recoverable using start/end_recovery commands

The userspace interface allows selection of combinations of these behaviors using flags specified at device creation time, namely:

default behavior: A + 1
UBLK_F_USER_RECOVERY: B + 2 UBLK_F_USER_RECOVERY|UBLK_F_USER_RECOVERY_REISSUE: C + 2

A + 2 is a currently unsupported behavior. This patch series aims to add support for it.

Userspace support and testing for this flag are available at:
https://github.com/ublk-org/ublksrv/pull/73

Uday Shankar (5):
ublk: check recovery flags for validity
ublk: refactor recovery configuration flag helpers
ublk: merge stop_work and quiesce_work
ublk: support device recovery without I/O queueing
Documentation: ublk: document UBLK_F_USER_RECOVERY_FAIL_IO

 Documentation/block/ublk.rst  |  24 +++--
 drivers/block/ublk_drv.c      | 191 +++++++++++++++++++++++-----------
 include/uapi/linux/ublk_cmd.h |  18 ++++
 3 files changed, 165 insertions(+), 68 deletions(-)

base-commit: 8faa82888e7109d91902260ecffd12291abb4bf6

Signature · 1 line
2.34.1