Skip to content

Last WQE Reached event treatment

Max Gurtovoy linux-nvme linux-rdma 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 3 repliesApplied
  2. v16 patches 12 repliesSuperseded

Changes in v2 from the cover letter

1. don't withhold the LAST_WQE_REACHED from the ULPs (Sagi)
2. Remove ULP update as a result from #1
3. Increase the wait_for_completion_timeout to 60 seconds

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2IB/core: add support for draining Shared receive queuesdrivers/infiniband/core/verbs.c include/rdma/ib_verbs.h+83 -11 reply
2/2IB/isert: remove the handling of last WQE reached eventdrivers/infiniband/ulp/isert/ib_isert.c+0 -31 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchSagi Grimberg
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] Last WQE Reached event treatment

Hi Jason/Leon/Sagi,

This series adds a support for draining a QP that is associated with a SRQ (Shared Receive Queue).
Leakage problem can occur if we won't treat Last WQE Reached event.

In the series, that is based on some old series I've send during 2018, I used a different approach and handled the event in the RDMA core, as was suggested in discussion in the mailing list.

In addition to the main patch 1/2 I've added another 2/2 to remove dead code.

I've tested this series with NVMf/RDMA on RoCE.

Changes from v1:
1. don't withhold the LAST_WQE_REACHED from the ULPs (Sagi)
2. Remove ULP update as a result from #1
3. Increase the wait_for_completion_timeout to 60 seconds

Max Gurtovoy (2):
IB/core: add support for draining Shared receive queues IB/isert: remove the handling of last WQE reached event

 drivers/infiniband/core/verbs.c         | 82 ++++++++++++++++++++++++-
 drivers/infiniband/ulp/isert/ib_isert.c |  3 -
 include/rdma/ib_verbs.h                 |  2 +
 3 files changed, 83 insertions(+), 4 deletions(-)
Signature · 1 line
2.18.1