Skip to content

hwmon: (spd5118) Various improvements

Guenter Roeck linux-hwmon lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest3 patches 14 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3hwmon: (spd5118) Use regmap to implement pagingdrivers/hwmon/spd5118.c+18 -290 replies
2/3hwmon: (spd5118) Use spd5118 specific read/write operationsdrivers/hwmon/Kconfig drivers/hwmon/spd5118.c+28 -213 replies
3/3hwmon: (spd5118) Add support for Renesas/ITD SPD5118 hub controllersdrivers/hwmon/spd5118.c+56 -00 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchArmin Wolf
SeriesT-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [RFT PATCH v2 0/3] hwmon: (spd5118) Various improvements

The first patch of this series introduces multi-page support using the regmap infrastructure. This simplifies the code and improves regmap caching.

The second patch introduces a spd5118-specific regmap bus to implement SMBus accesses. This solves a problem seen with i801 I2C controllers when writing to the chip. The I2C_FUNC_SMBUS_I2C_BLOCK support implemented in those controllers does not work with spd5118 compatible chips, so byte-by-byte access needs to be used explicitly.

The third patch adds support for spd5118 compatible chips which follow the standard literally and block access to volatile registers if not on page 0.

RFT: I was able to test the code on AMD systems using the piix4 I2C controller. It needs testing with i801 controllers and with Renesas chips.

v2: Added patches 1 and 2; simplified patch 3 to rely on regmap
based paging.

----------------------------------------------------------------
Guenter Roeck (3):
hwmon: (spd5118) Use regmap to implement paging
hwmon: (spd5118) Use spd5118 specific read/write operations
hwmon: (spd5118) Add support for Renesas/ITD SPD5118 hub controllers

 drivers/hwmon/Kconfig   |   2 +-
 drivers/hwmon/spd5118.c | 131 +++++++++++++++++++++++++++++++++++++-----------
 2 files changed, 102 insertions(+), 31 deletions(-)