Skip to content

Consider discard option when writing zeros

Nir Soffer qemu-devel 2 versions – Applied

Status from this message: Thanks, applied to my block tree:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 3 repliesApplied
  2. v21 patch 11 repliesSuperseded

Changes in v3 from the cover letter

- Add write-zeroes-unmap iotest
- Fix iotest missing discard=unmap

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/2qemu-iotest/245: Add missing discard=unmaptests/qemu-iotests/245+1 -11 reply
2/2Consider discard option when writing zerosblock/io.c tests/qemu-iotests/tests/write-zeroes-unmap tests/qemu-iotests/tests/write-zeroes-unmap.out+213 -41 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchStefan Hajnoczi
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] Consider discard option when writing zeros

Punch holes only when the image is opened with discard=on or discard=unmap.

Tested by:
- new write-zeroes-unmap iotest on xfs, ext4, and tmpfs
- tests/qemu-iotests/check -raw
- tests/qemu-iotests/check -qcow2

Changes since v2
- Add write-zeroes-unmap iotest
- Fix iotest missing discard=unmap

v2 was here:
https://lists.nongnu.org/archive/html/qemu-block/2024-06/msg00231.html

Nir Soffer (2):
qemu-iotest/245: Add missing discard=unmap
Consider discard option when writing zeros

 block/io.c                                    |   9 +-
 tests/qemu-iotests/245                        |   2 +-
 tests/qemu-iotests/tests/write-zeroes-unmap   | 127 ++++++++++++++++++
 .../qemu-iotests/tests/write-zeroes-unmap.out |  81 +++++++++++
 4 files changed, 214 insertions(+), 5 deletions(-)
 create mode 100755 tests/qemu-iotests/tests/write-zeroes-unmap
 create mode 100644 tests/qemu-iotests/tests/write-zeroes-unmap.out
Signature · 1 line
2.45.2