Skip to content

32-bit build issues

David Disseldorp linux-bcachefs 1 version Applied

Status from this message: Thanks, applied

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/1key: use c_long type for keyctl_search() helper fnsrc/key.rs+1 -11 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [tools PATCH 0/1] 32-bit build issues

I've run into a few 32-bit arch specific issues when attempting to package the latest v1.9.1 tools release:
- c_long vs i64 type mixing for keyctl_search()
* This one looks pretty straightforward, see follow-up PATCH 1/1 mail

- error[E0588]: packed type cannot transitively contain a #[repr(align)] type
* maybe related to https://github.com/rust-lang/rust-bindgen/issues/2179

       --> bcachefs-tools-1.9.1/target/release/build/bch_bindgen-ea7db20b4c53ec29/out/bcachefs.rs:32702:1
        |
  32702 | pub struct bkey_inode_buf {
        | ^^^^^^^^^^^^^^^^^^^^^^^^^
        |
  note: `bch_inode_v3` has a `#[repr(align)]` attribute
       --> bcachefs-tools-1.9.1/target/release/build/bch_bindgen-ea7db20b4c53ec29/out/bcachefs.rs:8988:1
        |
  8988  | pub struct bch_inode_v3 {
        | ^^^^^^^^^^^^^^^^^^^^^^^
  note: `bkey_inode_buf` contains a field of type `bkey_i_inode_v3`
       --> bcachefs-tools-1.9.1/target/release/build/bch_bindgen-ea7db20b4c53ec29/out/bcachefs.rs:32703:9
        |
  32703 |     pub inode: bkey_i_inode_v3,
        |         ^^^^^
  note: ...which contains a field of type `bch_inode_v3`
       --> bcachefs-tools-1.9.1/target/release/build/bch_bindgen-ea7db20b4c53ec29/out/bcachefs.rs:28906:9
        |

28906 | pub v: bch_inode_v3,
* see https://build.opensuse.org/public/build/home:ddiss:bcachefs_upstream_vendor/openSUSE_Tumbleweed/i586/bcachefs-tools/_log

- undefined reference to `atomic64_try_cmpxchg'
* this looks like an arm7l specific regression from the

    atomic64_cmpxchg -> atomic64_try_cmpxchg conversion in 7d79fba1a

* see https://build.opensuse.org/public/build/home:ddiss:bcachefs_upstream_vendor/openSUSE_Tumbleweed/armv7l/bcachefs-tools/_log

Logs for successful v1.7.0 builds can be found at
https://build.opensuse.org/public/build/filesystems/openSUSE_Tumbleweed/i586/bcachefs-tools/_log
https://build.opensuse.org/public/build/filesystems/openSUSE_Tumbleweed/armv7l/bcachefs-tools/_log

Cheers, David