Skip to content

Preparatory patches for BCM2712 (Pi5) support

Dave Stevenson dri-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest31 patches 3 repliesIn review
  2. v131 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- Sorted Maxime's email address (git log hid the old address due to mailmap)
- Added my missed SoB to Dom's patch
- Extended commit subjects to standardise and include what part of vc4 was being updated.
- Added Fixes tags to all appropriate patches
- Dropped "Limit max_bpc to 8 on Pi0-3" as that is already fixed by b47a72f30768f
- Added "drm/vc4: hvs: Correct logic on stopping an HVS channel" as it is a pre-2712 fix that I found as I was then adding the 2712 stuff on top.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/31drm/vc4: plane: Keep fractional source coords inside statedrivers/gpu/drm/vc4/vc4_drv.h drivers/gpu/drm/vc4/vc4_plane.c+34 -360 replies
2/31drm/vc4: plane: Handle fractional coordinates using the phase fielddrivers/gpu/drm/vc4/vc4_plane.c+76 -110 replies
3/31drm/vc4: crtc: Force trigger of dlist update on margins changedrivers/gpu/drm/vc4/vc4_crtc.c drivers/gpu/drm/vc4/vc4_drv.h+12 -100 replies
4/31drm/vc4: hdmi: Avoid log spam for audio start failuredrivers/gpu/drm/vc4/vc4_hdmi.c+1 -10 replies
5/31drm/vc4: plane: Add support for YUV444 formatsdrivers/gpu/drm/vc4/vc4_plane.c+18 -00 replies
6/31drm/vc4: hvs: Set AXI panic modes for the HVSdrivers/gpu/drm/vc4/vc4_hvs.c+11 -00 replies
7/31drm/vc4: hdmi: Increase audio MAI fifo dreq thresholddrivers/gpu/drm/vc4/vc4_hdmi.c+13 -50 replies
8/31drm/vc4: hdmi: Warn if writing to an unknown HDMI registerdrivers/gpu/drm/vc4/vc4_hdmi_regs.h+4 -10 replies
9/31drm/vc4: hvs: More logging for dlist generationdrivers/gpu/drm/vc4/vc4_hvs.c+12 -20 replies
10/31drm/vc4: hvs: Print error if we fail an allocationdrivers/gpu/drm/vc4/vc4_hvs.c drivers/gpu/drm/vc4/vc4_plane.c+8 -30 replies
11/31drm/vc4: plane: Add more debugging for LBM allocationdrivers/gpu/drm/vc4/vc4_plane.c+4 -00 replies
12/31drm/vc4: plane: Use return variable in atomic_checkdrivers/gpu/drm/vc4/vc4_plane.c+5 -10 replies
13/31drm/vc4: crtc: Move assigned_channel to a variabledrivers/gpu/drm/vc4/vc4_crtc.c+4 -30 replies
14/31drm/vc4: hvs: Don't write gamma luts on 2711drivers/gpu/drm/vc4/vc4_hvs.c+3 -00 replies
15/31drm/vc4: plane: YUV planes require vertical scaling to always be enableddrivers/gpu/drm/vc4/vc4_plane.c+6 -00 replies
16/31drm/vc4: hdmi: Avoid hang with debug registers when suspendeddrivers/gpu/drm/vc4/vc4_hdmi.c+4 -00 replies
17/31drm/vc4: hvs: Fix dlist debug not resetting the next entry pointerdrivers/gpu/drm/vc4/vc4_hvs.c+2 -10 replies
18/31drm/vc4: hvs: Remove incorrect limit from hvs_dlist debugfs functiondrivers/gpu/drm/vc4/vc4_drv.h drivers/gpu/drm/vc4/vc4_hvs.c+5 -20 replies
19/31drm/vc4: hvs: Remove ABORT_ON_EMPTY flagdrivers/gpu/drm/vc4/vc4_hdmi.c drivers/gpu/drm/vc4/vc4_regs.h+2 -00 replies
20/31drm/vc4: Introduce generation number enumdrivers/gpu/drm/vc4/tests/vc4_mock.c drivers/gpu/drm/vc4/vc4_bo.c drivers/gpu/drm/vc4/vc4_crtc.c +13 more+121 -1072 replies
21/31drm/vc4: Make v3d paths unavailable on any generation newer than vc4drivers/gpu/drm/vc4/vc4_bo.c drivers/gpu/drm/vc4/vc4_crtc.c drivers/gpu/drm/vc4/vc4_drv.c +8 more+59 -590 replies
22/31drm/vc4: hvs: Use switch statement to simplify vc4_hvs_get_fifo_from_outputdrivers/gpu/drm/vc4/vc4_hvs.c+42 -350 replies
23/31drm/vc4: hvs: Create hw_init functiondrivers/gpu/drm/vc4/vc4_hvs.c+83 -720 replies
24/31drm/vc4: hvs: Create cob_init functiondrivers/gpu/drm/vc4/vc4_hvs.c+74 -540 replies
25/31drm/vc4: hvs: Rename hvs_regs listdrivers/gpu/drm/vc4/vc4_hvs.c+3 -30 replies
26/31drm/vc4: plane: Change ptr0_offset to an arraydrivers/gpu/drm/vc4/vc4_drv.h drivers/gpu/drm/vc4/vc4_plane.c+11 -100 replies
27/31drm/vc4: hvs: Rework LBM alignmentdrivers/gpu/drm/vc4/vc4_plane.c+6 -20 replies
28/31drm/vc4: hvs: Change prototype of __vc4_hvs_alloc to pass registersdrivers/gpu/drm/vc4/tests/vc4_mock.c drivers/gpu/drm/vc4/vc4_drv.h drivers/gpu/drm/vc4/vc4_hvs.c+14 -80 replies
29/31drm/vc4: plane: Move the buffer offset out of the vc4_plane_statedrivers/gpu/drm/vc4/vc4_drv.h drivers/gpu/drm/vc4/vc4_plane.c+20 -360 replies
30/31drm/vc4: hvs: Enable SCALER_CONTROL early in HVS initdrivers/gpu/drm/vc4/vc4_hvs.c+8 -60 replies
31/31drm/vc4: hvs: Correct logic on stopping an HVS channeldrivers/gpu/drm/vc4/vc4_hvs.c+3 -50 replies

Reviews trailers per patch

None of the 31 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMaxime Ripard
SeriesR-b
1/31
2/31
3/31
4/31
5/31
6/31
7/31
8/31
9/31
10/31
11/31
12/31
13/31
14/31
15/31
16/31
17/31
18/31
19/31
20/31
21/31
22/31
23/31
24/31
25/31
26/31
27/31
28/31
29/31
30/31
31/31

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/31] Preparatory patches for BCM2712 (Pi5) support

Hi

This set is a number of minor fixes that we've had downstream for a while, and then lays down the some infrastructure changes to facilitate adding support of BCM2712. I'm just finalising those patches so they should follow on fairly soon.

Thanks
Dave

---
v1 -> v2

- Sorted Maxime's email address (git log hid the old address due to mailmap)
- Added my missed SoB to Dom's patch
- Extended commit subjects to standardise and include what part of vc4 was being updated.
- Added Fixes tags to all appropriate patches
- Dropped "Limit max_bpc to 8 on Pi0-3" as that is already fixed by b47a72f30768f
- Added "drm/vc4: hvs: Correct logic on stopping an HVS channel" as it is a pre-2712 fix that I found as I was then adding the 2712 stuff on top.

Dave Stevenson (8):
drm/vc4: crtc: Force trigger of dlist update on margins change drm/vc4: hvs: Set AXI panic modes for the HVS
drm/vc4: hvs: Don't write gamma luts on 2711
drm/vc4: plane: YUV planes require vertical scaling to always be
enabled
drm/vc4: hvs: Fix dlist debug not resetting the next entry pointer drm/vc4: hvs: Remove incorrect limit from hvs_dlist debugfs function drm/vc4: plane: Move the buffer offset out of the vc4_plane_state drm/vc4: hvs: Correct logic on stopping an HVS channel

Dom Cobley (7):
drm/vc4: plane: Keep fractional source coords inside state drm/vc4: plane: Handle fractional coordinates using the phase field drm/vc4: hdmi: Avoid log spam for audio start failure drm/vc4: plane: Add support for YUV444 formats
drm/vc4: hdmi: Increase audio MAI fifo dreq threshold drm/vc4: hdmi: Avoid hang with debug registers when suspended drm/vc4: hvs: Remove ABORT_ON_EMPTY flag

Maxime Ripard (15):
drm/vc4: hdmi: Warn if writing to an unknown HDMI register drm/vc4: hvs: More logging for dlist generation
drm/vc4: hvs: Print error if we fail an allocation drm/vc4: plane: Add more debugging for LBM allocation drm/vc4: plane: Use return variable in atomic_check drm/vc4: crtc: Move assigned_channel to a variable drm/vc4: Introduce generation number enum
drm/vc4: Make v3d paths unavailable on any generation newer than vc4 drm/vc4: hvs: Use switch statement to simplify
vc4_hvs_get_fifo_from_output
drm/vc4: hvs: Create hw_init function
drm/vc4: hvs: Create cob_init function
drm/vc4: hvs: Rename hvs_regs list
drm/vc4: plane: Change ptr0_offset to an array
drm/vc4: hvs: Rework LBM alignment
drm/vc4: hvs: Change prototype of __vc4_hvs_alloc to pass registers

Tim Gover (1):
drm/vc4: hvs: Enable SCALER_CONTROL early in HVS init

 drivers/gpu/drm/vc4/tests/vc4_mock.c       |  14 +-
 drivers/gpu/drm/vc4/vc4_bo.c               |  28 +-
 drivers/gpu/drm/vc4/vc4_crtc.c             |  35 +-
 drivers/gpu/drm/vc4/vc4_drv.c              |  22 +-
 drivers/gpu/drm/vc4/vc4_drv.h              |  29 +-
 drivers/gpu/drm/vc4/vc4_gem.c              |  24 +-
 drivers/gpu/drm/vc4/vc4_hdmi.c             |  25 +-
 drivers/gpu/drm/vc4/vc4_hdmi_regs.h        |   5 +-
 drivers/gpu/drm/vc4/vc4_hvs.c              | 351 +++++++++++++--------
 drivers/gpu/drm/vc4/vc4_irq.c              |  10 +-
 drivers/gpu/drm/vc4/vc4_kms.c              |  14 +-
 drivers/gpu/drm/vc4/vc4_perfmon.c          |  20 +-
 drivers/gpu/drm/vc4/vc4_plane.c            | 281 +++++++++++------
 drivers/gpu/drm/vc4/vc4_regs.h             |   1 +
 drivers/gpu/drm/vc4/vc4_render_cl.c        |   2 +-
 drivers/gpu/drm/vc4/vc4_v3d.c              |  10 +-
 drivers/gpu/drm/vc4/vc4_validate.c         |   8 +-
 drivers/gpu/drm/vc4/vc4_validate_shaders.c |   2 +-
 18 files changed, 538 insertions(+), 343 deletions(-)
Signature · 1 line
2.34.1