Skip to content

selftests: drv-net: rss_ctx: add tests for RSS contexts

Jakub Kicinski netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 10 repliesIn review 3 of 4 applied
  2. v24 patches 14 repliesSuperseded
  3. v14 patches 13 repliesSuperseded

Patches in v3 3 of 4 applied

#Subject and filesSizeRepliesApplied
1/4selftests: drv-net: try to check if port is in usetools/testing/selftests/net/lib/py/utils.py+13 -22 repliesApplied
2/4selftests: drv-net: add helper to wait for HW stats to synctools/testing/selftests/drivers/net/lib/py/env.py tools/testing/selftests/net/lib/py/utils.py+22 -12 repliesApplied
3/4selftests: drv-net: add ability to wait for at least N packets to load gentools/testing/selftests/drivers/net/lib/py/load.py+23 -72 repliesApplied
4/4selftests: drv-net: rss_ctx: add tests for RSS configuration and contextstools/testing/selftests/drivers/net/hw/Makefile tools/testing/selftests/drivers/net/hw/rss_ctx.py tools/testing/selftests/drivers/net/lib/py/load.py +2 more+399 -52 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchPrzemek KitszelBreno LeitaoPetr MachataWillem de Bruijn
1/4R-b R-b R-b
2/4R-b R-b
3/4R-b R-b R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH net-next v3 0/4] selftests: drv-net: rss_ctx: add tests for RSS contexts

Add a few tests exercising RSS context API.
In addition to basic sanity checks, tests add RSS contexts, n-tuple rule to direct traffic to them (based on dst port), and qstats to make sure traffic landed where we expected.

v2 adds a test for removing contexts out of order. When testing bnxt - either the new test or running more tests after the overlap test makes the device act strangely. To the point where it may start giving out ntuple IDs of 0 for all rules..

Ed, could you try the tests with your device?

  $ export NETIF=eth0 REMOTE_...
  $ ./drivers/net/hw/rss_ctx.py
  KTAP version 1
  1..8
  ok 1 rss_ctx.test_rss_key_indir
  ok 2 rss_ctx.test_rss_context
  ok 3 rss_ctx.test_rss_context4
  # Increasing queue count 44 -> 66
  # Failed to create context 32, trying to test what we got
  ok 4 rss_ctx.test_rss_context32 # SKIP Tested only 31 contexts, wanted 32
  ok 5 rss_ctx.test_rss_context_overlap
  ok 6 rss_ctx.test_rss_context_overlap2
  # .. sprays traffic like a headless chicken ..
  not ok 7 rss_ctx.test_rss_context_out_of_order
  ok 8 rss_ctx.test_rss_context4_create_with_cfg
  # Totals: pass:6 fail:1 xfail:0 xpass:0 skip:1 error:0

v2: https://lore.kernel.org/all/[email protected]
v1: https://lore.kernel.org/all/[email protected]

Jakub Kicinski (4):
selftests: drv-net: try to check if port is in use
selftests: drv-net: add helper to wait for HW stats to sync
selftests: drv-net: add ability to wait for at least N packets to load
gen
selftests: drv-net: rss_ctx: add tests for RSS configuration and
contexts

 .../testing/selftests/drivers/net/hw/Makefile |   1 +
 .../selftests/drivers/net/hw/rss_ctx.py       | 383 ++++++++++++++++++
 .../selftests/drivers/net/lib/py/env.py       |  19 +-
 .../selftests/drivers/net/lib/py/load.py      |  37 +-
 tools/testing/selftests/net/lib/py/ksft.py    |   5 +
 tools/testing/selftests/net/lib/py/utils.py   |  27 +-
 6 files changed, 457 insertions(+), 15 deletions(-)
 create mode 100755 tools/testing/selftests/drivers/net/hw/rss_ctx.py
Signature · 1 line
2.45.2