Skip to content

add zpdesc memory descriptor for zswap.zpool

[email protected] linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15mm/z3fold: add zpdesc struct and helper and use them in z3fold_page_isolatemm/z3fold.c mm/zpdesc.h+59 -60 replies
2/15mm/z3fold: use zpdesc in z3fold_page_migratemm/z3fold.c mm/zpdesc.h+26 -140 replies
3/15mm/z3fold: use zpdesc in z3fold_page_putbackmm/z3fold.c+3 -20 replies
4/15mm/z3fold: use zpdesc in get/put_z3fold_header funcsmm/z3fold.c+4 -40 replies
5/15mm/z3fold: use zpdesc in init_z3fold_pagemm/z3fold.c+8 -70 replies
6/15mm/z3fold: use zpdesc in free_z3fold_pagemm/z3fold.c mm/zpdesc.h+16 -40 replies
7/15mm/z3fold: convert page to zpdesc in __release_z3fold_pagemm/z3fold.c+3 -30 replies
8/15mm/z3fold: use zpdesc free_pages_workmm/z3fold.c+3 -30 replies
9/15mm/z3fold: use zpdesc in z3fold_compact_page and do_compact_pagemm/z3fold.c+9 -100 replies
10/15mm/z3fold: use zpdesc in __z3fold_allocmm/z3fold.c+7 -70 replies
11/15mm/z3fold: use zpdesc in z3fold_allocmm/z3fold.c mm/zpdesc.h+19 -150 replies
12/15mm/z3fold: use zpdesc in free_z3fold_page and z3fold_freemm/z3fold.c+12 -140 replies
13/15mm/z3fold: use zpdesc in z3fold_map/z3fold_unmapmm/z3fold.c+8 -80 replies
14/15mm/z3fold: introduce __zpdesc_set_movablemm/z3fold.c mm/zpdesc.h+9 -30 replies
15/15mm/z3fold: introduce __zpdesc_clear_movablemm/z3fold.c mm/zpdesc.h+7 -20 replies

Reviews trailers per patch

None of the 15 patches has a Reviewed-by or Acked-by.

PatchHyeonggon Yoo
1/15Originally-by
2/15
3/15
4/15
5/15
6/15
7/15
8/15
9/15
10/15
11/15Originally-by
12/15
13/15
14/15Originally-by
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/15] add zpdesc memory descriptor for zswap.zpool

From: Alex Shi <[email protected]>

According to Metthew's plan, the page descriptor will be replace by a 8 bytes mem_desc on destination purpose.
https://lore.kernel.org/lkml/[email protected]/

Here is a implement on z3fold to replace page descriptor by zpdesc, which is still overlay on struct page now. but it's a step move forward above destination.

To name the struct zpdesc instead of z3fold_desc, since there are 3 zpool usages under zswap, zbud, z3fold, zsmalloc. It looks like we may extend the zpdesc to zbud and zsmalloc, combined their usage into one.

For zpdesc(page), z3fold just uses the 5th member zppage_flag, which match with page.private. Potentially uses the first member flags for headless PG_locked, list_head lru and page.mapping|PAGE_MAPPING_MOVABLE for page migration.

This patachset could save 26Kbyetes z3fold.o size, basely saving come from the page to folio conversion.

Thanks a lot!
Alex

Alex Shi (15):
mm/z3fold: add zpdesc struct and helper and use them in
z3fold_page_isolate
mm/z3fold: use zpdesc in z3fold_page_migrate mm/z3fold: use zpdesc in z3fold_page_putback mm/z3fold: use zpdesc in get/put_z3fold_header funcs mm/z3fold: use zpdesc in init_z3fold_page
mm/z3fold: use zpdesc in free_z3fold_page
mm/z3fold: convert page to zpdesc in __release_z3fold_page mm/z3fold: use zpdesc free_pages_work
mm/z3fold: use zpdesc in z3fold_compact_page and do_compact_page mm/z3fold: use zpdesc in __z3fold_alloc
mm/z3fold: use zpdesc in z3fold_alloc
mm/z3fold: use zpdesc in free_z3fold_page and z3fold_free mm/z3fold: use zpdesc in z3fold_map/z3fold_unmap mm/z3fold: introduce __zpdesc_set_movable
mm/z3fold: introduce __zpdesc_clear_movable

 mm/z3fold.c | 190 +++++++++++++++++++++++++++-------------------------
 mm/zpdesc.h |  87 ++++++++++++++++++++++++
 2 files changed, 184 insertions(+), 93 deletions(-)
 create mode 100644 mm/zpdesc.h
Signature · 1 line
2.43.0