mm/mprotect: Fix dax puds
Status from this message: [merged mm-stable] mm-mprotect-fix-dax-pud-handlings.patch removed from -mm tree
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest7 patches 7 repliesApplied 7/7
- v47 patches 20 repliesSuperseded
- v38 patches 16 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 8 patches | 1 reply | Superseded | |
| v1 | 7 patches | 9 replies | Superseded |
Changes in v5 from the cover letter
- Rename patch subject "mm/x86: arch_check_zapped_pud()", add "Implement" [tglx]
- Mostly rewrote commit messages for the x86 patches, follow -tip rules [tglx]
- Line wrap fixes (to mostly avoid newlines when unnecessary) [tglx]
- English fixes [tglx]
- Fix a build issue only happens with i386 pae + clang
https://lore.kernel.org/r/[email protected]
Patches in v5 All 7 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | mm/dax: Dump start address in fault handlerdrivers/ | +3 | 0 replies | Applied |
| 2/7 | mm/mprotect: Push mmu notifier to PUDsmm/ | +16 | 0 replies | Applied |
| 3/7 | mm/powerpc: Add missing pud helpersarch/ arch/ | +23 | 0 replies | Applied |
| 4/7 | mm/x86: Make pud_leaf() only care about PSE bitarch/ | +1 | 0 replies | Applied |
| 5/7 | mm/x86: Implement arch_check_zapped_pud()arch/ arch/ include/ +1 more | +25 | 0 replies | Applied |
| 6/7 | mm/x86: Add missing pud helpersarch/ arch/ | +61 | 0 replies | Applied |
| 7/7 | mm/mprotect: fix dax pud handlingsinclude/ mm/ mm/ | +107 | 0 replies | Applied |
Reviews trailers per patch
3 of 7 patches have a Reviewed-by or Acked-by.
| Patch | David Hildenbrand | Dave Hansen |
|---|---|---|
| 1/7 | A-b | |
| 2/7 | ||
| 3/7 | ||
| 4/7 | R-b | A-b |
| 5/7 | A-b | |
| 6/7 | ||
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 0/7] mm/mprotect: Fix dax puds
[Based on mm-unstable, commit 98808d08fc0f, Aug 7th. NOTE: it is
intentional to not have rebased to latest mm-unstable, as this is to replace the queued v4]
v5 Changelog:
- Rename patch subject "mm/x86: arch_check_zapped_pud()", add "Implement" [tglx]
- Mostly rewrote commit messages for the x86 patches, follow -tip rules [tglx]
- Line wrap fixes (to mostly avoid newlines when unnecessary) [tglx]
- English fixes [tglx]
- Fix a build issue only happens with i386 pae + clang
https://lore.kernel.org/r/[email protected]
v1: https://lore.kernel.org/r/[email protected]
v2: https://lore.kernel.org/r/[email protected]
v3: https://lore.kernel.org/r/[email protected]
v4: https://lore.kernel.org/r/[email protected]
Dax supports pud pages for a while, but mprotect on puds was missing since the start. This series tries to fix that by providing pud handling in mprotect(). The goal is to add more types of pud mappings like hugetlb or pfnmaps. This series paves way for it by fixing known pud entries.
Considering nobody reported this until when I looked at those other types of pud mappings, I am thinking maybe it doesn't need to be a fix for stable and this may not need to be backported. I would guess whoever cares about mprotect() won't care 1G dax puds yet, vice versa. I hope fixing that in new kernels would be fine, but I'm open to suggestions.
There're a few small things changed to teach mprotect work on PUDs. E.g. it will need to start with dropping NUMA_HUGE_PTE_UPDATES which may stop making sense when there can be more than one type of huge pte. OTOH, we'll also need to push the mmu notifiers from pmd to pud layers, which might need some attention but so far I think it's safe. For such details, please refer to each patch's commit message.
The mprotect() pud process should be straightforward, as I kept it as simple as possible. There's no NUMA handled as dax simply doesn't support that. There's also no userfault involvements as file memory (even if work with userfault-wp async mode) will need to split a pud, so pud entry doesn't need to yet know userfault's existance (but hugetlb entries will; that's also for later).
Tests
=====
What I did test:
- cross-build tests that I normally cover [1]
- smoke tested on x86_64 the simplest program [2] on dev_dax 1G PUD mprotect() using QEMU's nvdimm emulations [3] and ndctl to create namespaces with proper alignments, which used to throw "bad pud" but now it'll run through all fine. I checked sigbus happens if with illegal access on protected puds.
- vmtests.
What I didn't test:
- fsdax: I wanted to also give it a shot, but only until then I noticed it doesn't seem to be supported (according to dax_iomap_fault(), which will always fallback on PUD_ORDER). I did remember it was supported before, I could miss something important there.. please shoot if so.
- userfault wp-async: I also wanted to test userfault-wp async be able to split huge puds (here it's simply a clear_pud.. though), but it won't work for devdax anyway due to not allowed to do smaller than 1G faults in this case. So skip too.
- Power, as no hardware on hand.
Thanks,
[1] https://gitlab.com/peterx/lkb-harness/-/blob/main/config.json
[2] https://github.com/xzpeter/clibs/blob/master/misc/dax.c
[3] https://github.com/qemu/qemu/blob/master/docs/nvdimm.txt
Peter Xu (7):
mm/dax: Dump start address in fault handler
mm/mprotect: Push mmu notifier to PUDs
mm/powerpc: Add missing pud helpers
mm/x86: Make pud_leaf() only care about PSE bit
mm/x86: Implement arch_check_zapped_pud()
mm/x86: Add missing pud helpers
mm/mprotect: fix dax pud handlings
arch/powerpc/include/asm/book3s/64/pgtable.h | 3 + arch/powerpc/mm/book3s64/pgtable.c | 20 ++++++ arch/x86/include/asm/pgtable.h | 70 ++++++++++++++++--- arch/x86/mm/pgtable.c | 18 +++++ drivers/dax/device.c | 6 +- include/linux/huge_mm.h | 24 +++++++ include/linux/pgtable.h | 6 ++ mm/huge_memory.c | 56 ++++++++++++++- mm/mprotect.c | 71 +++++++++++++------- 9 files changed, 236 insertions(+), 38 deletions(-)
Signature · 1 line
2.45.0