Skip to content

Add per-client engine utilization tests

Umesh Nerlige Ramappa igt-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 21 repliesIn review
  2. v18 patches 11 repliesSuperseded

Changes in v2 from the cover letter

- Add a test to destroy exec queue before capturing sample
- Include review comments from Lucas/Riana

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10tests/intel/xe_drm_fdinfo: Rename basic to basic-memory testtests/intel/xe_drm_fdinfo.c+6 -64 replies
2/10tests/intel/xe_drm_fdinfo: Add basic-engine-utilization testtests/intel/xe_drm_fdinfo.c+29 -32 replies
3/10tests/intel/xe_drm_fdinfo: Add helper to read utilization for all classestests/intel/xe_drm_fdinfo.c+20 -03 replies
4/10tests/intel/xe_drm_fdinfo: Add helpers for spinning batchestests/intel/xe_drm_fdinfo.c+135 -04 replies
5/10tests/intel/xe_drm_fdinfo: Add single engine teststests/intel/xe_drm_fdinfo.c+97 -04 replies
6/10tests/intel/xe_drm_fdinfo: Add tests to verify all class utilizationtests/intel/xe_drm_fdinfo.c+130 -00 replies
7/10tests/intel/xe_drm_fdinfo: Add an iterator for virtual enginestests/intel/xe_drm_fdinfo.c+29 -04 replies
8/10tests/intel/xe_drm_fdinfo: Add tests for virtual enginestests/intel/xe_drm_fdinfo.c+70 -10 replies
9/10tests/intel/xe_drm_fdinfo: Add tests for parallel enginestests/intel/xe_drm_fdinfo.c+31 -30 replies
10/10tests/intel/xe_drm_fdinfo: Ensure queue destroy records load correctlytests/intel/xe_drm_fdinfo.c+33 -00 replies

Reviews trailers per patch

2 of 10 patches have a Reviewed-by or Acked-by.

PatchLucas De Marchi
1/10R-b
2/10R-b
3/10
4/10
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH i-g-t v2 00/10] Add per-client engine utilization tests

Port per client engine utilization tests from i915 to xe.

v2:
- Add a test to destroy exec queue before capturing sample
- Include review comments from Lucas/Riana

Opens from v1 review
---
1) Documenting mapping for TEST_BUSY/TEST_TRAILING_IDLE etc to tests
- Not seeing a clean way to do this since some tests iterate over all engine and some over virtual engines and then some tests omit hwe/width/count params. Would leave it as is if acceptable.

2) Busyness > 100%
- sampling RING_TIMESTAMP before utilization values is likely leading to this error. Ideally RING TIMESTAMP should be sampled before 1st sample and after 2nd sample, but that's not feasible. It can only be one way for each sample - either before or after.

Umesh Nerlige Ramappa (10):
tests/intel/xe_drm_fdinfo: Rename basic to basic-memory test tests/intel/xe_drm_fdinfo: Add basic-engine-utilization test tests/intel/xe_drm_fdinfo: Add helper to read utilization for all
classes
tests/intel/xe_drm_fdinfo: Add helpers for spinning batches tests/intel/xe_drm_fdinfo: Add single engine tests tests/intel/xe_drm_fdinfo: Add tests to verify all class utilization tests/intel/xe_drm_fdinfo: Add an iterator for virtual engines tests/intel/xe_drm_fdinfo: Add tests for virtual engines tests/intel/xe_drm_fdinfo: Add tests for parallel engines tests/intel/xe_drm_fdinfo: Ensure queue destroy records load correctly

 tests/intel/xe_drm_fdinfo.c | 587 +++++++++++++++++++++++++++++++++++-
 1 file changed, 577 insertions(+), 10 deletions(-)
Signature · 1 line
2.38.1