Skip to content

serial: qcom-geni: fix lockups

Johan Hovold linux-arm-msm linux-serial lkml stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 7 repliesIn review
  2. v13 patches 15 repliesSuperseded

Changes in v2 from the cover letter

- restart tx by issuing a transfer command when there is stale data in the fifo
- reorder and rename patches
- rename cancel tx helper

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3serial: qcom-geni: fix soft lockup on sw flow control and suspenddrivers/tty/serial/qcom_geni_serial.c+24 -90 replies
2/3serial: qcom-geni: fix hard lockup on buffer flushdrivers/tty/serial/qcom_geni_serial.c+13 -30 replies
3/3serial: qcom-geni: do not kill the machine on fifo underrundrivers/tty/serial/qcom_geni_serial.c+1 -14 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] serial: qcom-geni: fix lockups

Since 6.10-rc1, Qualcomm machines with a serial port can easily lock up hard, for example, when stopping a getty on reboot.

This was triggered by the kfifo conversion, which turned an existing bug that caused the driver to print discarded characters after a buffer flush into a hard lockup.

This series fixes the regression and a related soft lockup issue that can be triggered on software flow control and on suspend.

Doug has posted an alternative series of fixes here that depends on reworking the driver a fair bit here:

	https://lore.kernel.org/lkml/[email protected]/

This rework has a significant impact on performance on some platforms, but fortunately it seems such a rework can be avoided.

There are further bugs in the console code (e.g. that can lead to lost characters) that this series does not address, but those can be fixed separately (and I've started working on that).

Johan

Changes in v2
- restart tx by issuing a transfer command when there is stale data in the fifo
- reorder and rename patches
- rename cancel tx helper

Johan Hovold (3):
serial: qcom-geni: fix soft lockup on sw flow control and suspend
serial: qcom-geni: fix hard lockup on buffer flush
serial: qcom-geni: do not kill the machine on fifo underrun

 drivers/tty/serial/qcom_geni_serial.c | 51 ++++++++++++++++++++-------
 1 file changed, 38 insertions(+), 13 deletions(-)
Signature · 1 line
2.44.1