Skip to content

hw/sd/sd: Introduce sd_cmd_to_receivingdata() / sd_generic_write_byte()

Philippe Mathieu-Daudé qemu-devel 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 0 repliesNew
  2. v17 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7hw/sd/sdcard: Introduce sd_cmd_to_receivingdata / sd_generic_write_bytehw/sd/sd.c+29 -00 replies
2/7hw/sd/sdcard: Duplicate WRITE_SINGLE_BLOCK / WRITE_MULTIPLE_BLOCK caseshw/sd/sd.c+29 -00 replies
3/7hw/sd/sdcard: Convert WRITE_SINGLE_BLOCK to generic_write_byte (CMD24)hw/sd/sd.c+2 -90 replies
4/7hw/sd/sdcard: Convert PROGRAM_CID to generic_write_byte (CMD26)hw/sd/sd.c+2 -130 replies
5/7hw/sd/sdcard: Convert PROGRAM_CSD to generic_write_byte (CMD27)hw/sd/sd.c+2 -130 replies
6/7hw/sd/sdcard: Convert LOCK_UNLOCK to generic_write_byte (CMD42)hw/sd/sd.c+2 -130 replies
7/7hw/sd/sdcard: Convert GEN_CMD to generic_write_byte (CMD56)hw/sd/sd.c+3 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/7] hw/sd/sd: Introduce sd_cmd_to_receivingdata() / sd_generic_write_byte()

Consolitate writing bytes on the DAT lines by introducing a pair of helpers to reuse in all commands receiving data.

I'm considering adding some 'process_completed_block' callbacks to handle the different cases in sd_write_byte(), so this function would become:

  if (sd_generic_write_byte(sd, value)) {
      sd->proto->process_completed_block[sd->current_cmd](sd);
   }

But I ran out of time...

Full series for testing:
https://gitlab.com/philmd/qemu/-/tags/emmc-v4

Based-on: <[email protected]>

Philippe Mathieu-Daudé (7):
hw/sd/sdcard: Introduce sd_cmd_to_receivingdata /
sd_generic_write_byte
hw/sd/sdcard: Duplicate WRITE_SINGLE_BLOCK / WRITE_MULTIPLE_BLOCK
cases
hw/sd/sdcard: Convert WRITE_SINGLE_BLOCK to generic_write_byte (CMD24) hw/sd/sdcard: Convert PROGRAM_CID to generic_write_byte (CMD26) hw/sd/sdcard: Convert PROGRAM_CSD to generic_write_byte (CMD27) hw/sd/sdcard: Convert LOCK_UNLOCK to generic_write_byte (CMD42) hw/sd/sdcard: Convert GEN_CMD to generic_write_byte (CMD56)

 hw/sd/sd.c | 109 ++++++++++++++++++++++++++++++-----------------------
 1 file changed, 62 insertions(+), 47 deletions(-)
Signature · 1 line
2.41.0