Skip to content

Fix scalability problem in workqueue watchdog touch caused by stop_machine

Nicholas Piggin lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4workqueue: wq_watchdog_touch is always called with valid CPUkernel/workqueue.c+2 -00 replies
2/4workqueue: Improve scalability of workqueue watchdog touchkernel/workqueue.c+8 -24 replies
3/4stop_machine: Rearrange multi_cpu_stop state machine loopkernel/stop_machine.c+15 -100 replies
4/4stop_machine: Add a delay between multi_cpu_stop touching watchdogskernel/stop_machine.c+12 -20 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPaul E. McKenney
SeriesR-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] Fix scalability problem in workqueue watchdog touch caused by stop_machine

Here are a few patches to fix a lockup caused by very slow progress due to a scalability problem in workqueue watchdog touch being hammered by thousands of CPUs in multi_cpu_stop. Patch 2 is the fix.

I did notice when making a microbenchmark reproducer that the RCU call was actually also causing slowdowns. Not nearly so bad as the workqueue touch, but workqueue queueing of dummy jobs slowed down by a factor of several times when lots of other CPUs were making rcu_momentary_dyntick_idle() calls. So I did the stop_machine patches to reduce that. So those patches 3,4 are independent of the first two and can go in any order.

Thanks,
Nick

Nicholas Piggin (4):
workqueue: wq_watchdog_touch is always called with valid CPU
workqueue: Improve scalability of workqueue watchdog touch
stop_machine: Rearrange multi_cpu_stop state machine loop
stop_machine: Add a delay between multi_cpu_stop touching watchdogs

 kernel/stop_machine.c | 31 +++++++++++++++++++++++--------
 kernel/workqueue.c    | 12 ++++++++++--
 2 files changed, 33 insertions(+), 10 deletions(-)
Signature · 1 line
2.45.1