Fix scalability problem in workqueue watchdog touch caused by stop_machine
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 8 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | workqueue: wq_watchdog_touch is always called with valid CPUkernel/ | +2 | 0 replies | |
| 2/4 | workqueue: Improve scalability of workqueue watchdog touchkernel/ | +8 | 4 replies | |
| 3/4 | stop_machine: Rearrange multi_cpu_stop state machine loopkernel/ | +15 | 0 replies | |
| 4/4 | stop_machine: Add a delay between multi_cpu_stop touching watchdogskernel/ | +12 | 0 replies |
Reviews trailers per patch
None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Paul E. McKenney |
|---|---|
| Series | R-b |
| 1/4 | |
| 2/4 | |
| 3/4 | |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/4] Fix scalability problem in workqueue watchdog touch caused by stop_machine
Here are a few patches to fix a lockup caused by very slow progress due to a scalability problem in workqueue watchdog touch being hammered by thousands of CPUs in multi_cpu_stop. Patch 2 is the fix.
I did notice when making a microbenchmark reproducer that the RCU call was actually also causing slowdowns. Not nearly so bad as the workqueue touch, but workqueue queueing of dummy jobs slowed down by a factor of several times when lots of other CPUs were making rcu_momentary_dyntick_idle() calls. So I did the stop_machine patches to reduce that. So those patches 3,4 are independent of the first two and can go in any order.
Thanks,
Nick
Nicholas Piggin (4):
workqueue: wq_watchdog_touch is always called with valid CPU
workqueue: Improve scalability of workqueue watchdog touch
stop_machine: Rearrange multi_cpu_stop state machine loop
stop_machine: Add a delay between multi_cpu_stop touching watchdogs
kernel/stop_machine.c | 31 +++++++++++++++++++++++-------- kernel/workqueue.c | 12 ++++++++++-- 2 files changed, 33 insertions(+), 10 deletions(-)
Signature · 1 line
2.45.1