Skip to content

RFC Adjust page pool netlink filling to non common case

Amit Cohen netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4net: core: page_pool_user: Allow flexibility of 'ifindex' valuenet/core/page_pool_user.c+10 -120 replies
2/4net: core: page_pool_user: Change 'ifindex' for page pool dumpnet/core/page_pool_user.c+1 -10 replies
3/4mlxsw: pci: Allow get page pool info/stats via netlinkdrivers/net/ethernet/mellanox/mlxsw/pci.c+1 -00 replies
4/4mlxsw: Set page pools list for netdevicesdrivers/net/ethernet/mellanox/mlxsw/core.c drivers/net/ethernet/mellanox/mlxsw/core.h drivers/net/ethernet/mellanox/mlxsw/pci.c +1 more+18 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH RFC net-next 0/4] Adjust page pool netlink filling to non common case

Most network drivers has 1:1 mapping between netdevice and event queues, so then each page pool is used by only one netdevice. This is not the case in mlxsw driver.

Currently, the netlink message is filled with 'pool->slow.netdev->ifindex', which should be NULL in case that several netdevices use the same pool. Adjust page pool netlink filling to use the netdevice which the pool is stored in its list. See more info in commit messages.

Without this set, mlxsw driver cannot dump all page pools:

$ ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
	--dump page-pool-stats-get --output-json | jq
[]

With this set, "dump" command prints all the page pools for all the netdevices:

$ ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
	--dump page-pool-get --output-json | \
	jq -e ".[] | select(.ifindex == 64)" | grep "napi-id" | wc -l
56

From driver POV, such queries are supported by associating the pools with an unregistered netdevice (dummy netdevice). The following limitations are caused by such implementation:
1. The get command output specifies the 'ifindex' as 0, which is meaningless. iproute2 will print this as "*", but there might be other tools which fail in such case.
2. get command does not work when devlink instance is reloaded to namespace which is not the initial one, as the dummy device associated with the pools belongs to the initial namespace.
See examples in commit messages.

We would like to expose page pool stats and info via the standard interface, but such implementation is not perfect. An additional option is to use debugfs, but we prefer to avoid it, if it is possible. Any suggestions for better implementation in case of pool for several netdevices will be welcomed.

Patch set overview:
Patch #1 makes netlink filling code more flex
Patch #2 changes the 'ifindex' which is used for dump
Patch #3 sets netdevice for page pools in mlxsw driver, to allow "do" commands
Patch #4 sets page pools list for netdevices in mlxsw driver, to allow "dump" commands

Amit Cohen (4):
net: core: page_pool_user: Allow flexibility of 'ifindex' value
net: core: page_pool_user: Change 'ifindex' for page pool dump
mlxsw: pci: Allow get page pool info/stats via netlink
mlxsw: Set page pools list for netdevices

 drivers/net/ethernet/mellanox/mlxsw/core.c    |  6 +++++
 drivers/net/ethernet/mellanox/mlxsw/core.h    |  2 ++
 drivers/net/ethernet/mellanox/mlxsw/pci.c     |  9 ++++++++
 .../net/ethernet/mellanox/mlxsw/spectrum.c    |  2 ++
 net/core/page_pool_user.c                     | 22 +++++++++----------
 5 files changed, 29 insertions(+), 12 deletions(-)
Signature · 1 line
2.45.1