Skip to content

Constify tool pointers

Ian Rogers linux-arm-kernel linux-perf-users lkml 7 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest27 patches 0 repliesNew
  2. v627 patches 12 repliesSuperseded
  3. v527 patches 2 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v428 patches0 repliesSuperseded
v328 patches3 repliesSuperseded
v227 patches5 repliesSuperseded
v126 patches2 repliesSuperseded

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/27perf auxtrace: Remove dummy toolstools/perf/util/arm-spe.c tools/perf/util/cs-etm.c tools/perf/util/intel-bts.c +3 more+41 -1230 replies
2/27perf s390-cpumsf: Remove unused structtools/perf/util/s390-cpumsf.c+0 -50 replies
3/27perf tool: Constify tool pointerstools/perf/arch/x86/util/event.c tools/perf/bench/synthesize.c tools/perf/builtin-annotate.c +46 more+314 -3160 replies
4/27perf tool: Move fill defaults into tool.ctools/perf/util/Build tools/perf/util/session.c tools/perf/util/session.h +2 more+331 -3110 replies
5/27perf tool: Add perf_tool__inittools/perf/util/tool.c tools/perf/util/tool.h+59 -00 replies
6/27perf kmem: Use perf_tool__inittools/perf/builtin-kmem.c+8 -90 replies
7/27perf buildid-list: Use perf_tool__inittools/perf/builtin-buildid-list.c tools/perf/util/build-id.c tools/perf/util/build-id.h +2 more+35 -350 replies
8/27perf kvm: Use perf_tool__inittools/perf/builtin-kvm.c+6 -90 replies
9/27perf lock: Use perf_tool__inittools/perf/builtin-lock.c+18 -190 replies
10/27perf evlist: Use perf_tool__inittools/perf/builtin-evlist.c+5 -50 replies
11/27perf record: Use perf_tool__inittools/perf/builtin-record.c tools/perf/util/tool.c tools/perf/util/tool.h+31 -180 replies
12/27perf c2c: Use perf_tool__inittools/perf/builtin-c2c.c+13 -180 replies
13/27perf script: Use perf_tool__inittools/perf/builtin-script.c+30 -350 replies
14/27perf inject: Use perf_tool__inittools/perf/builtin-inject.c+43 -480 replies
15/27perf report: Use perf_tool__inittools/perf/builtin-report.c+27 -280 replies
16/27perf stat: Use perf_tool__inittools/perf/builtin-stat.c+9 -90 replies
17/27perf annotate: Use perf_tool__inittools/perf/builtin-annotate.c+20 -220 replies
18/27perf sched: Use perf_tool__inittools/perf/builtin-sched.c+7 -90 replies
19/27perf mem: Use perf_tool__inittools/perf/builtin-mem.c+17 -160 replies
20/27perf timechart: Use perf_tool__inittools/perf/builtin-timechart.c+8 -90 replies
21/27perf diff: Use perf_tool__inittools/perf/builtin-diff.c+13 -150 replies
22/27perf data convert json: Use perf_tool__inittools/perf/util/data-convert-json.c+20 -230 replies
23/27perf data convert ctf: Use perf_tool__inittools/perf/util/data-convert-bt.c+14 -160 replies
24/27perf test event_update: Ensure tools is initializedtools/perf/tests/event_update.c+1 -00 replies
25/27perf kwork: Use perf_tool__inittools/perf/builtin-kwork.c+5 -60 replies
26/27perf tool: Remove perf_tool__fill_defaultstools/perf/util/session.c tools/perf/util/tool.c tools/perf/util/tool.h+0 -960 replies
27/27perf session: Constify tooltools/perf/util/session.c tools/perf/util/session.h+4 -40 replies

Reviews trailers per patch

3 of 27 patches have a Reviewed-by or Acked-by.

PatchAdrian HunterLeo Yan
1/27R-b T-b T-b
2/27R-b
3/27R-b T-b T-b
4/27
5/27
6/27
7/27
8/27
9/27
10/27
11/27
12/27
13/27
14/27
15/27
16/27
17/27
18/27
19/27
20/27
21/27
22/27
23/27
24/27
25/27
26/27
27/27

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 00/27] Constify tool pointers

struct perf_tool provides a set of function pointers that are called through when processing perf data. To make filling the pointers less cumbersome, if they are NULL perf_tools__fill_defaults will add default do nothing implementations.

This change refactors struct perf_tool to have an init function that provides the default implementation. The special use of NULL and perf_tools__fill_defaults are removed. As a consequence the tool pointers can then all be made const, which better reflects the behavior a particular perf command would expect of the tool and to some extent can reduce the cognitive load on someone working on a command.

v7: Rebase and correct Adrian's reviewed-by tags.
v6: Rebase adding Adrian's reviewed-by/tested-by and Leo's tested-by.
v5: Rebase dropping asan fix merged by Namhyung.
v4: Simplify perf_session__deliver_synth_attr_event following Adrian's
suggestions.
v3: Just remove auxtrace dummy tools [Adrian] and make s390-cpumsf
struct removal its own patch [Adrian].
v2: Remove dummy tool initialization [Adrian] and make zero sized. Add
cs-etm fix for address sanitizer build, found necessary when testing dummy tool change.

Ian Rogers (27):
perf auxtrace: Remove dummy tools
perf s390-cpumsf: Remove unused struct
perf tool: Constify tool pointers
perf tool: Move fill defaults into tool.c perf tool: Add perf_tool__init
perf kmem: Use perf_tool__init
perf buildid-list: Use perf_tool__init
perf kvm: Use perf_tool__init
perf lock: Use perf_tool__init
perf evlist: Use perf_tool__init
perf record: Use perf_tool__init
perf c2c: Use perf_tool__init
perf script: Use perf_tool__init
perf inject: Use perf_tool__init
perf report: Use perf_tool__init
perf stat: Use perf_tool__init
perf annotate: Use perf_tool__init
perf sched: Use perf_tool__init
perf mem: Use perf_tool__init
perf timechart: Use perf_tool__init
perf diff: Use perf_tool__init
perf data convert json: Use perf_tool__init perf data convert ctf: Use perf_tool__init perf test event_update: Ensure tools is initialized perf kwork: Use perf_tool__init
perf tool: Remove perf_tool__fill_defaults perf session: Constify tool

 tools/perf/arch/x86/util/event.c    |   4 +-
 tools/perf/bench/synthesize.c       |   2 +-
 tools/perf/builtin-annotate.c       |  44 ++--
 tools/perf/builtin-buildid-list.c   |  10 +
 tools/perf/builtin-c2c.c            |  33 ++-
 tools/perf/builtin-diff.c           |  30 ++-
 tools/perf/builtin-evlist.c         |  10 +-
 tools/perf/builtin-inject.c         | 161 ++++++------
 tools/perf/builtin-kmem.c           |  20 +-
 tools/perf/builtin-kvm.c            |  19 +-
 tools/perf/builtin-kwork.c          |  33 ++-
 tools/perf/builtin-lock.c           |  41 ++--
 tools/perf/builtin-mem.c            |  37 +--
 tools/perf/builtin-record.c         |  47 ++--
 tools/perf/builtin-report.c         |  67 +++--
 tools/perf/builtin-sched.c          |  50 ++--
 tools/perf/builtin-script.c         | 106 ++++----
 tools/perf/builtin-stat.c           |  26 +-
 tools/perf/builtin-timechart.c      |  25 +-
 tools/perf/builtin-top.c            |   2 +-
 tools/perf/builtin-trace.c          |   4 +-
 tools/perf/tests/cpumap.c           |   6 +-
 tools/perf/tests/dlfilter-test.c    |   2 +-
 tools/perf/tests/dwarf-unwind.c     |   2 +-
 tools/perf/tests/event_update.c     |   9 +-
 tools/perf/tests/stat.c             |   6 +-
 tools/perf/tests/thread-map.c       |   2 +-
 tools/perf/util/Build               |   1 +
 tools/perf/util/arm-spe.c           |  55 +----
 tools/perf/util/auxtrace.c          |  12 +-
 tools/perf/util/auxtrace.h          |  20 +-
 tools/perf/util/bpf-event.c         |   4 +-
 tools/perf/util/build-id.c          |  34 +--
 tools/perf/util/build-id.h          |   8 +-
 tools/perf/util/cs-etm.c            |  39 +--
 tools/perf/util/data-convert-bt.c   |  34 ++-
 tools/perf/util/data-convert-json.c |  47 ++--
 tools/perf/util/event.c             |  54 ++--
 tools/perf/util/event.h             |  38 +--
 tools/perf/util/header.c            |   6 +-
 tools/perf/util/header.h            |   4 +-
 tools/perf/util/hisi-ptt.c          |   6 +-
 tools/perf/util/intel-bts.c         |  37 +--
 tools/perf/util/intel-pt.c          |  30 +--
 tools/perf/util/jitdump.c           |   4 +-
 tools/perf/util/s390-cpumsf.c       |  11 +-
 tools/perf/util/session.c           | 366 +++-------------------------
 tools/perf/util/session.h           |   9 +-
 tools/perf/util/synthetic-events.c  |  80 +++---
 tools/perf/util/synthetic-events.h  |  70 +++---
 tools/perf/util/tool.c              | 294 ++++++++++++++++++++++
 tools/perf/util/tool.h              |  18 +-
 tools/perf/util/tsc.c               |   2 +-
 53 files changed, 978 insertions(+), 1103 deletions(-)
 create mode 100644 tools/perf/util/tool.c
Signature · 1 line
2.46.0.76.ge559c4bf1a-goog