Skip to content

Move comment closer to the code it describes

[email protected] dtrace 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest38 patches 58 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/38Move comment closer to the code it describeslibdtrace/dt_prov_uprobe.c+4 -30 replies
2/38Move dt_spec_buf_data_t and dt_spec_buf_t into dt_consume.clibdtrace/dt_consume.c libdtrace/dt_impl.h+18 -181 reply
3/38Get rid of apparently orphaned status[2]cmd/dtrace.c+1 -31 reply
4/38Get rid of apparently orphaned bufdesc stuffcmd/dtrace.c include/dtrace/buffer.h include/dtrace/buffer_defines.h +2 more+2 -711 reply
5/38Get rid of unneeded enabling_defines.hinclude/dtrace/enabling.h include/dtrace/enabling_defines.h+1 -251 reply
6/38Get rid of unused dtrace_repldesc_tinclude/dtrace/enabling.h+0 -51 reply
7/38Clean up prp/pprp/uprp variable nameslibdtrace/dt_prov_uprobe.c+55 -282 replies
8/38Fix comment in dt_probe.clibdtrace/dt_probe.c+1 -11 reply
9/38Fix comments that hardwire DBUF_ offsetslibdtrace/dt_cg.c+2 -21 reply
10/38Fix comments in dt_cg.clibdtrace/dt_cg.c+2 -22 replies
11/38USDT module names may contain dots; but forbid "." and ".." namesdtprobed/dof_stash.c+14 -161 reply
12/38USDT module names may contain dots; remove incorrect checklibdtrace/dt_pid.c+0 -81 reply
13/38Hide dtrace_actdesc_t until it is neededinclude/dtrace/enabling.h+3 -04 replies
14/38Remove orphaned dtrace_hdl_t component dt_maxformatlibdtrace/dt_impl.h+0 -11 reply
15/38Remove orphaned dtrace_hdl_t component dt_prov_usdtlibdtrace/dt_impl.h+0 -11 reply
16/38Move dt_probe_clause_t to be available outside of dt_probe.clibdtrace/dt_impl.h libdtrace/dt_probe.c+5 -51 reply
17/38Add a provider-specific probe_add_clause handlelibdtrace/dt_probe.c libdtrace/dt_provider.h+5 -02 replies
18/38Add a provider-specific probe_add_clause for underlying probeslibdtrace/dt_prov_uprobe.c+34 -02 replies
19/38Retain probe descriptionslibdtrace/dt_impl.h libdtrace/dt_program.c+38 -14 replies
20/38Add a hook for a provider-specific "update" functionlibdtrace/dt_provider.h+2 -02 replies
21/38Add some commentslibdtrace/dt_prov_uprobe.c+2 -01 reply
22/38Fix aggs comment in dt_cg_tramp_prologue_act()libdtrace/dt_cg.c+0 -112 replies
23/38test: Clean up the specsize teststest/unittest/speculation/tst.SpecSizeVariations.r test/unittest/speculation/tst.SpecSizeVariations.sh test/unittest/speculation/tst.SpecSizeVariations4.d +3 more+142 -1390 replies
24/38test: Make test independent of specific PCtest/unittest/error/tst.DTRACEFLT_UNKNOWN.d test/unittest/error/tst.DTRACEFLT_UNKNOWN.r+4 -42 replies
25/38test: Clean up tests still expecting obsolete "at DIF offset NN"test/demo/dtrace/error.d test/demo/dtrace/error.r test/unittest/assocs/tst.invalidref.r +13 more+13 -231 reply
26/38test: Annotate xfail (chill not implemented yet)test/unittest/speculation/tst.zerosize.d+1 -14 replies
27/38test: Fix the speculative tests that checked bufsizetest/unittest/options/err.bufsize-negative.d test/unittest/options/err.bufsize-negative.r test/unittest/speculation/err.BufSizeVariations1.d +3 more+26 -2030 replies
28/38Remove unused "next" arg from dt_flowindent()libdtrace/dt_consume.c+3 -211 reply
29/38Allow relocation of the ERROR PRIDlibdtrace/dt_bpf.h libdtrace/dt_cc.c libdtrace/dt_dlibs.c+5 -02 replies
30/38Allow relocation on BPF_OR instructionslibdtrace/dt_as.c+2 -03 replies
31/38Fix dt_pebs_init() calllibdtrace/dt_peb.c libdtrace/dt_peb.h libdtrace/dt_work.c +4 more+71 -6111 replies
32/38Widen the EPID to include the PRIDbpf/get_bvar.c bpf/probe_error.c include/dtrace/universal.h +83 more+174 -1480 replies
33/38Eliminate dt_pdesclibdtrace/dt_cc.c libdtrace/dt_consume.c libdtrace/dt_handle.c +2 more+12 -440 replies
34/38Create the BPF uprobes maplibdtrace/dt_bpf.c libdtrace/dt_dlibs.c libdtrace/dt_impl.h +1 more+109 -00 replies
35/38Use uprobes map to call clauses conditionallylibdtrace/dt_prov_uprobe.c+68 -790 replies
36/38Inline copyout_val()libdtrace/dt_prov_uprobe.c+8 -300 replies
37/38Fix some dctx->mst->specsize commentslibdtrace/dt_cg.c+3 -31 reply
38/38Systemwide USDT WIPlibdtrace/dt_cc.c libdtrace/dt_pid.c test/unittest/dtrace-util/tst.ListProbesNameUSDT.sh +2 more+119 -200 replies

Reviews trailers per patch

17 of 38 patches have a Reviewed-by or Acked-by.

PatchKris Van Hees
1/38R-b
2/38R-b
3/38R-b
4/38R-b
5/38R-b
6/38R-b
7/38
8/38R-b
9/38R-b
10/38
11/38R-b
12/38R-b
13/38
14/38R-b
15/38R-b
16/38
17/38
18/38
19/38
20/38
21/38R-b
22/38R-b
23/38
24/38
25/38R-b
26/38
27/38
28/38
29/38
30/38R-b
31/38
32/38
33/38
34/38
35/38
36/38
37/38R-b
38/38

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread