Skip to content

net: phy: aquantia: enable support for aqr115c

Bartosz Golaszewski linux-tegra lkml netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 2/24 patches 15 repliesApplied 4/4
  2. v3 posting 1/24 patches 4 repliesSuperseded
  3. v23 patches 11 repliesSuperseded

Changes in v3 from the cover letter

- add a patch that addresses an issue with GLOBAL_CFG registers returning 0
- reuse aqr113c_config_init() for aqr115c
- improve commit messages, give more details on the 2500BASEX mode reuse Link to v2: https://lore.kernel.org/lkml/[email protected]/T/

Patches in v3 posting 2/2 All 4 applied

#Subject and filesSizeRepliesApplied
1/4net: phy: aquantia: rename and export aqr107_wait_reset_complete()drivers/net/phy/aquantia/aquantia.h drivers/net/phy/aquantia/aquantia_main.c+5 -30 repliesApplied
2/4net: phy: aquantia: wait for FW reset before checking the vendor IDdrivers/net/phy/aquantia/aquantia_firmware.c+4 -04 repliesApplied
3/4net: phy: aquantia: wait for the GLOBAL_CFG to start returning real valuesdrivers/net/phy/aquantia/aquantia_main.c+7 -111 repliesApplied
4/4net: phy: aquantia: add support for aqr115cdrivers/net/phy/aquantia/aquantia_main.c+26 -00 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [RESEND PATCH net-next v3 0/4] net: phy: aquantia: enable support for aqr115c

From: Bartosz Golaszewski <[email protected]>

Resending rebased on top of current net-next.

This series addesses two issues with the aqr115c PHY on Qualcomm sa8775p-ride-r3 board and adds support for this PHY to the aquantia driver.

While the manufacturer calls the 2.5G PHY mode OCSGMII, we reuse the existing 2500BASEX mode in the kernel to avoid extending the uAPI.

It took me a while to resend because I noticed an issue with the PHY coming out of suspend with no possible interfaces listed and tracked it to the GLOBAL_CFG registers for different modes returning 0. A workaround has been added to the series. Unfortunately the HPG doesn't mention a proper way of doing it or even mention any such issue at all.

Changes since v2:
- add a patch that addresses an issue with GLOBAL_CFG registers returning 0
- reuse aqr113c_config_init() for aqr115c
- improve commit messages, give more details on the 2500BASEX mode reuse Link to v2: https://lore.kernel.org/lkml/[email protected]/T/

Changes since v1:
- split out the PHY patches into their own series
- don't introduce new mode (OCSGMII) but use existing 2500BASEX instead
- split the wait-for-FW patch into two: one renaming and exporting the relevant function and the second using it before checking the FW ID
Link to v1: https://lore.kernel.org/linux-arm-kernel/[email protected]/T/

Bartosz Golaszewski (4):
net: phy: aquantia: rename and export aqr107_wait_reset_complete()
net: phy: aquantia: wait for FW reset before checking the vendor ID
net: phy: aquantia: wait for the GLOBAL_CFG to start returning real
values
net: phy: aquantia: add support for aqr115c

 drivers/net/phy/aquantia/aquantia.h          |  2 +
 drivers/net/phy/aquantia/aquantia_firmware.c |  4 ++
 drivers/net/phy/aquantia/aquantia_main.c     | 40 ++++++++++++++++++--
 3 files changed, 42 insertions(+), 4 deletions(-)
Signature · 1 line
2.43.0