Skip to content

drm/ast: Untangle the chaos in mode setting

Thomas Zimmermann dri-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm/ast: Implement atomic enable/disable for encodersdrivers/gpu/drm/ast/ast_mode.c+50 -161 reply
2/8drm/ast: Program mode for AST DP in atomic_mode_setdrivers/gpu/drm/ast/ast_mode.c+12 -51 reply
3/8drm/ast: Move mode-setting code into mode_set_nofb CRTC helperdrivers/gpu/drm/ast/ast_mode.c+28 -241 reply
4/8drm/ast: Handle primary-plane format setup in atomic_updatedrivers/gpu/drm/ast/ast_mode.c+3 -82 replies
5/8drm/ast: Remove gamma LUT updates from DPMS codedrivers/gpu/drm/ast/ast_mode.c+0 -121 reply
6/8drm/ast: Only set VGA SCREEN_DISABLE bit in CRTC codedrivers/gpu/drm/ast/ast_mode.c drivers/gpu/drm/ast/ast_reg.h+8 -71 reply
7/8drm/ast: Inline ast_crtc_dpms() into callersdrivers/gpu/drm/ast/ast_mode.c drivers/gpu/drm/ast/ast_reg.h+13 -321 reply
8/8drm/ast: Use drm_atomic_helper_commit_tail() helperdrivers/gpu/drm/ast/ast_mode.c+1 -11 reply

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchJocelyn Falempe
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] drm/ast: Untangle the chaos in mode setting

The CRTC's mode-setting code contains quite a bit of code that belongs to the planes or various encoder chips. This patchset refactors these bits and moves things to the correct places.

With the patches applied, the remaining DPMS function will be gone and its content be moved. Several code duplications will be removed. There was also a bugfix wrt the VGA SCREEN_DISABLE bit, but it's unclear if the bug had any effect in practice.

Tested with AST2100 and AST2600 with VGA and DP outputs.

Thomas Zimmermann (8):
drm/ast: Implement atomic enable/disable for encoders drm/ast: Program mode for AST DP in atomic_mode_set drm/ast: Move mode-setting code into mode_set_nofb CRTC helper drm/ast: Handle primary-plane format setup in atomic_update drm/ast: Remove gamma LUT updates from DPMS code drm/ast: Only set VGA SCREEN_DISABLE bit in CRTC code drm/ast: Inline ast_crtc_dpms() into callers drm/ast: Use drm_atomic_helper_commit_tail() helper

 drivers/gpu/drm/ast/ast_mode.c | 204 ++++++++++++++++++---------------
 drivers/gpu/drm/ast/ast_reg.h  |  10 +-
 2 files changed, 112 insertions(+), 102 deletions(-)
Signature · 1 line
2.45.2