Skip to content

hwmon: (amc6821) Various improvements

Guenter Roeck linux-hwmon lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest11 patches 2 repliesIn review
  2. v311 patches 4 repliesSuperseded
  3. v211 patches 13 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v110 patches26 repliesSuperseded

Changes in v4 from the cover letter

- Added Quentin's Reviewed-by: tag to patch 11/11
- Various improvements in regmap conversion see patch 9/11 for details
- Fixed subject of two patches

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11hwmon: (amc6821) Stop accepting invalid pwm valuesdrivers/hwmon/amc6821.c+8 -60 replies
2/11hwmon: (amc6821) Make reading and writing fan speed limits consistentdrivers/hwmon/amc6821.c+9 -40 replies
3/11hwmon: (amc6821) Rename fan1_div to fan1_pulsesDocumentation/hwmon/amc6821.rst drivers/hwmon/amc6821.c+14 -140 replies
4/11hwmon: (amc6821) Add support for fan1_target and pwm1_enable mode 4Documentation/hwmon/amc6821.rst drivers/hwmon/amc6821.c+21 -80 replies
5/11hwmon: (amc6821) Reorder include files, drop unnecessary onesdrivers/hwmon/amc6821.c+6 -70 replies
6/11hwmon: (amc6821) Use tabs for column alignment in definesdrivers/hwmon/amc6821.c+64 -640 replies
7/11hwmon: (amc6821) Use BIT() and GENMASK()drivers/hwmon/amc6821.c+36 -350 replies
8/11hwmon: (amc6821) Drop unnecessary enum chipsdrivers/hwmon/amc6821.c+1 -40 replies
9/11hwmon: (amc6821) Convert to use regmapdrivers/hwmon/Kconfig drivers/hwmon/amc6821.c+381 -4422 replies
10/11hwmon: (amc6821) Convert to with_info APIdrivers/hwmon/amc6821.c+390 -3540 replies
11/11hwmon: (amc6821) Add support for pwm1_mode attributeDocumentation/hwmon/amc6821.rst drivers/hwmon/amc6821.c+16 -10 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchQuentin Schulz
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/11] hwmon: (amc6821) Various improvements

Cleanup and modernize the amc2821 driver.

Summary of changes:

- Stop accepting invalid pwm values.
- Improve consistency of reading vs. writing fan speed limits
- Rename fan1_div to fan1_pulses
- Add support for fan1_target and pwm1_enable mode 4
- Reorder include files, drop unnecessary ones
- Use tabs for column alignment in defines
- Use BIT() and GENMASK()
- Drop unnecessary enum chips
- Convert to use regmap
- Convert to with_info API
- Add support for pwm1_mode attribute

v4:
- Added Quentin's Reviewed-by: tag to patch 11/11
- Various improvements in regmap conversion see patch 9/11 for details
- Fixed subject of two patches

v3:
- Added Quentin's Reviewed-by: tag to several patches
- Change valid range of pwm1_auto_point2_pwm from [0..254] to [0, 255]
- Various improvements of regmap conversion
- Fix register when writing pwm1_mode

v2:
- Use kstrtou8() instead of kstrtol() where possible
- Limit range of pwm1_auto_point_pwm to 0..254 in patch 1 instead of limiting it later, and do not accept invalid values for the attribute
- Do not accept negative fan speed values
- Display fan speed and speed limit as 0 if register value is 0 (instead of 6000000), as in original code
- Only permit writing 0 (unlimited) for the maximum fan speed
- Add Reviewed-by: tags where given
- Fix definition of AMC6821_CONF1_FDRC1 in patch 7/10
- Use sign_extend32() instead of odd type cast
- Drop remaining spurious debug message in patch 9 instead of patch 10
- Add missing "select REGMAP_I2C" to Kconfig
- Change misleading variable name from 'mask' to 'mode'
- Use sysfs_emit instead of sprintf everywhere
- Add support for pwm1_mode attribute

----------------------------------------------------------------
Guenter Roeck (11):
hwmon: (amc6821) Stop accepting invalid pwm values
hwmon: (amc6821) Make reading and writing fan speed limits consistent
hwmon: (amc6821) Rename fan1_div to fan1_pulses
hwmon: (amc6821) Add support for fan1_target and pwm1_enable mode 4
hwmon: (amc6821) Reorder include files, drop unnecessary ones
hwmon: (amc6821) Use tabs for column alignment in defines
hwmon: (amc6821) Use BIT() and GENMASK()
hwmon: (amc6821) Drop unnecessary enum chips
hwmon: (amc6821) Convert to use regmap
hwmon: (amc6821) Convert to with_info API
hwmon: (amc6821) Add support for pwm1_mode attribute

 Documentation/hwmon/amc6821.rst |    7 +-
 drivers/hwmon/Kconfig           |    1 +
 drivers/hwmon/amc6821.c         | 1401 ++++++++++++++++++++-------------------
 3 files changed, 708 insertions(+), 701 deletions(-)