Skip to content

Let create*_workqueue() accept a printf-style format string

Bart Van Assche lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest52 of 53 patches 18 repliesIn review

52 of 53 patches are in this archive. The cover letter announces 53.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/53workqueue: Introduce the create*_workqueue2() macrosinclude/linux/workqueue.h+9 -06 replies
2/53dmaengine: idxd: Switch to create*_workqueue2()drivers/dma/idxd/cdev.c drivers/dma/idxd/init.c+2 -20 replies
3/53drm/amdgpu: Switch to create*_workqueue2()drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c+1 -10 replies
4/53media: i2c: adv7511: Switch to create*_workqueue2()drivers/media/i2c/adv7511-v4l2.c+1 -10 replies
5/53media: cobalt: Switch to create*_workqueue2()drivers/media/pci/cobalt/cobalt-driver.c+1 -10 replies
6/53media: dm1105: Switch to create*_workqueue2()drivers/media/pci/dm1105/dm1105.c+1 -10 replies
7/53misc: bcm_vk: Switch to create*_workqueue2()drivers/misc/bcm-vk/bcm_vk_dev.c+1 -10 replies
8/53net: amd-xgbe: Switch to create*_workqueue2()drivers/net/ethernet/amd/xgbe/xgbe-drv.c+2 -20 replies
9/53net: atlantic: Switch to create*_workqueue2()drivers/net/ethernet/aquantia/atlantic/aq_main.c+1 -10 replies
10/53net: mvpp2: Switch to create*_workqueue2()drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c+2 -10 replies
11/53remoteproc: stm32: Switch to create*_workqueue2()drivers/remoteproc/stm32_rproc.c+1 -10 replies
12/53mm/z3fold: Switch to create*_workqueue2()mm/z3fold.c+2 -20 replies
13/53usb: typec: tcpm: Switch to create*_workqueue2()drivers/usb/typec/tcpm/fusb302.c+1 -10 replies
14/53net/qla3xxx: Switch to create*_workqueue2()drivers/net/ethernet/qlogic/qla3xxx.c+1 -10 replies
15/53sfc: Switch to create*_workqueue2()drivers/net/ethernet/sfc/efx_common.c drivers/net/ethernet/sfc/falcon/efx.c drivers/net/ethernet/sfc/siena/efx_common.c+6 -30 replies
16/53wifi: zd1211rw: Switch to create*_workqueue2()drivers/net/wireless/zydas/zd1211rw/zd_usb.c+1 -10 replies
17/53power: supply: mt6370: Switch to create*_workqueue2()drivers/power/supply/mt6370-charger.c+1 -10 replies
18/53remoteproc: imx_rproc: Switch to create*_workqueue2()drivers/remoteproc/imx_rproc.c+1 -10 replies
19/53scsi: hisi_sas: Switch to create*_workqueue2()drivers/scsi/hisi_sas/hisi_sas_main.c+1 -10 replies
20/53scsi: mpt3sas: Switch to create*_workqueue2()drivers/scsi/mpt3sas/mpt3sas_base.c+2 -20 replies
21/53accel/habanalabs: Simplify the workqueue creation callsdrivers/accel/habanalabs/common/device.c+12 -130 replies
22/53crypto: safexcel - Simplify a create*_workqueue() calldrivers/crypto/inside-secure/safexcel.c+1 -30 replies
23/53pds_core: Simplify a create*_workqueue() calldrivers/net/ethernet/amd/pds_core/main.c+2 -52 replies
24/53net: bna: Simplify a create*_workqueue() calldrivers/net/ethernet/brocade/bna/bnad.c drivers/net/ethernet/brocade/bna/bnad.h+2 -30 replies
25/53net/mlx5: Simplify the create*_workqueue() callsdrivers/net/ethernet/mellanox/mlx5/core/cmd.c drivers/net/ethernet/mellanox/mlx5/core/health.c drivers/net/ethernet/mellanox/mlx5/core/sf/vhca_event.c +1 more+6 -260 replies
26/53net: lan966x: Simplify a create*_workqueue() calldrivers/net/ethernet/microchip/lan966x/lan966x_ethtool.c+2 -50 replies
27/53net: sparx5: Simplify the create*_workqueue() callsdrivers/net/ethernet/microchip/sparx5/sparx5_ethtool.c drivers/net/ethernet/microchip/sparx5/sparx5_main.c+4 -80 replies
28/53net: mscc: ocelot: Simplify a create*_workqueue() calldrivers/net/ethernet/mscc/ocelot_stats.c+2 -40 replies
29/53net: qed: Simplify a create*_workqueue() calldrivers/net/ethernet/qlogic/qed/qed_sriov.c+3 -60 replies
30/53net: stmmac: Simplify a create*_workqueue() calldrivers/net/ethernet/stmicro/stmmac/stmmac.h drivers/net/ethernet/stmicro/stmmac/stmmac_main.c+4 -80 replies
31/53nfc: mrvl: Simplify a create*_workqueue() calldrivers/nfc/nfcmrvl/fw_dnld.c+3 -53 replies
32/53scsi: ibmvscsi_tgt: Simplify a create*_workqueue() calldrivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c+1 -30 replies
33/53scsi: libsas: Simplify the create*_workqueue() callsdrivers/scsi/libsas/sas_init.c+4 -52 replies
34/53scsi: mpi3mr: Simplify a create*_workqueue() calldrivers/scsi/mpi3mr/mpi3mr_fw.c+2 -20 replies
35/53scsi: qedf: Simplify the create*_workqueue() callsdrivers/scsi/qedf/qedf_main.c+6 -110 replies
36/53scsi: qedi: Simplify the create*_workqueue() callsdrivers/scsi/qedi/qedi_main.c+4 -40 replies
37/53scsi: qla2xxx: Simplify the create*_workqueue() callsdrivers/scsi/qla2xxx/qla_os.c+5 -50 replies
38/53scsi: qla4xxx: Simplify a create*_workqueue() calldrivers/scsi/qla4xxx/ql4_os.c+2 -30 replies
39/53scsi: vmw_pvscsi: Simplify a create*_workqueue() calldrivers/scsi/vmw_pvscsi.c+2 -60 replies
40/53scsi: myrb: Simplify the create*_workqueue() callsdrivers/scsi/myrb.c drivers/scsi/myrb.h+2 -40 replies
41/53scsi: myrs: Simplify the create*_workqueue() callsdrivers/scsi/myrs.c drivers/scsi/myrs.h+2 -40 replies
42/53scsi: stex: Simplify the create*_workqueue() callsdrivers/scsi/stex.c+2 -40 replies
43/53scsi: fcoe: Simplify the create*_workqueue() callsdrivers/scsi/fcoe/fcoe_sysfs.c include/scsi/fcoe_sysfs.h+1 -70 replies
44/53scsi: snic: Simplify the create*_workqueue() callsdrivers/scsi/snic/snic_main.c+2 -30 replies
45/53scsi: scsi_transport_fc: Simplify the create*_workqueue() callsdrivers/scsi/scsi_transport_fc.c include/scsi/scsi_transport_fc.h+1 -60 replies
46/53scsi: core: Simplify the alloc_workqueue() callsdrivers/scsi/hosts.c include/scsi/scsi_host.h+4 -60 replies
47/53serial: max3100: Simplify a create*_workqueue() calldrivers/tty/serial/max3100.c+1 -31 reply
48/53scsi: ufs: Simplify the create*_workqueue() callsdrivers/ufs/core/ufshcd.c+4 -90 replies
49/53usb: typec: ucsi: Simplify a create*_workqueue() calldrivers/usb/typec/ucsi/ucsi.c+2 -70 replies
50/53cifs: Simplify a create*_workqueue() callfs/smb/client/smbdirect.c+1 -20 replies
51/53mac802154: Simplify the create*_workqueue() callsnet/mac802154/main.c+3 -40 replies
52/53nfc: nci: Simplify the create*_workqueue() callsnet/nfc/nci/core.c+6 -71 reply

Reviews trailers per patch

5 of 52 patches have a Reviewed-by or Acked-by.

PatchDamien Le MoalJason YanKrzysztof KozlowskiBrett CreeleyAndy Shevchenko
1/53
2/53
3/53
4/53
5/53
6/53
7/53
8/53
9/53
10/53
11/53
12/53
13/53
14/53
15/53
16/53
17/53
18/53
19/53
20/53
21/53
22/53
23/53R-b
24/53
25/53
26/53
27/53
28/53
29/53
30/53
31/53R-b
32/53
33/53R-b R-b
34/53
35/53
36/53
37/53
38/53
39/53
40/53
41/53
42/53
43/53
44/53
45/53
46/53
47/53R-b
48/53
49/53
50/53
51/53
52/53R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 00/53] Let create*_workqueue() accept a printf-style format string

Hi Tejun,

A significant amount of kernel code formats the workqueue name before it calls a workqueue creation function. This patch series simplifies such kernel code and modifies the create*_workqueue() macros such that these accept a printf-style format string and argument list.

The approach of this patch series is as follows:
1. Introduce the create*_workqueue2() macros that accept a printf-style format string and argument list.
2. Convert all workqueue creation calls that might pass a name that includes a formatting character from create*_workqueue(name) into create*_workqueue2("%s", name).
3. Convert all workqueue creation code that is preceded by workqueue name formatting code into a create*_workqueue2(fmt, args) call.
4. Convert all create*_workqueue2() calls into create*_workqueue() calls, remove the original create*_workqueue() calls and rename the new create*_workqueue2() macros into create*_workqueue().

Please consider this patch series for the next merge window.

Thanks,

Bart.

Bart Van Assche (53):
workqueue: Introduce the create*_workqueue2() macros
dmaengine: idxd: Switch to create*_workqueue2() drm/amdgpu: Switch to create*_workqueue2()
media: i2c: adv7511: Switch to create*_workqueue2()
media: cobalt: Switch to create*_workqueue2()
media: dm1105: Switch to create*_workqueue2()
misc: bcm_vk: Switch to create*_workqueue2()
net: amd-xgbe: Switch to create*_workqueue2()
net: atlantic: Switch to create*_workqueue2()
net: mvpp2: Switch to create*_workqueue2()
remoteproc: stm32: Switch to create*_workqueue2() mm/z3fold: Switch to create*_workqueue2()
usb: typec: tcpm: Switch to create*_workqueue2() net/qla3xxx: Switch to create*_workqueue2()
sfc: Switch to create*_workqueue2()
wifi: zd1211rw: Switch to create*_workqueue2()
power: supply: mt6370: Switch to create*_workqueue2()
remoteproc: imx_rproc: Switch to create*_workqueue2()
scsi: hisi_sas: Switch to create*_workqueue2()
scsi: mpt3sas: Switch to create*_workqueue2() accel/habanalabs: Simplify the workqueue creation calls
crypto: safexcel - Simplify a create*_workqueue() call
pds_core: Simplify a create*_workqueue() call
net: bna: Simplify a create*_workqueue() call net/mlx5: Simplify the create*_workqueue() calls
net: lan966x: Simplify a create*_workqueue() call
net: sparx5: Simplify the create*_workqueue() calls
net: mscc: ocelot: Simplify a create*_workqueue() call
net: qed: Simplify a create*_workqueue() call
net: stmmac: Simplify a create*_workqueue() call
nfc: mrvl: Simplify a create*_workqueue() call
scsi: ibmvscsi_tgt: Simplify a create*_workqueue() call
scsi: libsas: Simplify the create*_workqueue() calls
scsi: mpi3mr: Simplify a create*_workqueue() call
scsi: qedf: Simplify the create*_workqueue() calls
scsi: qedi: Simplify the create*_workqueue() calls
scsi: qla2xxx: Simplify the create*_workqueue() calls
scsi: qla4xxx: Simplify a create*_workqueue() call
scsi: vmw_pvscsi: Simplify a create*_workqueue() call
scsi: myrb: Simplify the create*_workqueue() calls
scsi: myrs: Simplify the create*_workqueue() calls
scsi: stex: Simplify the create*_workqueue() calls
scsi: fcoe: Simplify the create*_workqueue() calls
scsi: snic: Simplify the create*_workqueue() calls
scsi: scsi_transport_fc: Simplify the create*_workqueue() calls
scsi: core: Simplify the alloc_workqueue() calls
serial: max3100: Simplify a create*_workqueue() call
scsi: ufs: Simplify the create*_workqueue() calls
usb: typec: ucsi: Simplify a create*_workqueue() call
cifs: Simplify a create*_workqueue() call
mac802154: Simplify the create*_workqueue() calls
nfc: nci: Simplify the create*_workqueue() calls
workqueue: Rename create*_workqueue2() into create*_workqueue()

 drivers/accel/habanalabs/common/device.c      | 25 +++++++++----------
 drivers/crypto/inside-secure/safexcel.c       |  4 +--
 drivers/dma/idxd/cdev.c                       |  2 +-
 drivers/dma/idxd/init.c                       |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c     |  2 +-
 drivers/media/i2c/adv7511-v4l2.c              |  2 +-
 drivers/media/pci/cobalt/cobalt-driver.c      |  2 +-
 drivers/media/pci/dm1105/dm1105.c             |  2 +-
 drivers/misc/bcm-vk/bcm_vk_dev.c              |  2 +-
 drivers/net/ethernet/amd/pds_core/main.c      |  7 ++----
 drivers/net/ethernet/amd/xgbe/xgbe-drv.c      |  4 +--
 .../net/ethernet/aquantia/atlantic/aq_main.c  |  2 +-
 drivers/net/ethernet/brocade/bna/bnad.c       |  4 +--
 drivers/net/ethernet/brocade/bna/bnad.h       |  1 -
 .../net/ethernet/marvell/mvpp2/mvpp2_main.c   |  3 ++-
 drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 12 ++-------
 .../net/ethernet/mellanox/mlx5/core/health.c  | 10 ++------
 .../mellanox/mlx5/core/sf/vhca_event.c        |  5 ++--
 .../microchip/lan966x/lan966x_ethtool.c       |  7 ++----
 .../microchip/sparx5/sparx5_ethtool.c         |  6 ++---
 .../ethernet/microchip/sparx5/sparx5_main.c   |  6 ++---
 drivers/net/ethernet/mscc/ocelot_stats.c      |  6 ++---
 drivers/net/ethernet/qlogic/qed/qed_sriov.c   |  9 +++----
 drivers/net/ethernet/qlogic/qla3xxx.c         |  2 +-
 drivers/net/ethernet/sfc/efx_common.c         |  3 ++-
 drivers/net/ethernet/sfc/falcon/efx.c         |  3 ++-
 drivers/net/ethernet/sfc/siena/efx_common.c   |  3 ++-
 drivers/net/ethernet/stmicro/stmmac/stmmac.h  |  1 -
 .../net/ethernet/stmicro/stmmac/stmmac_main.c | 11 +++-----
 drivers/net/wireless/zydas/zd1211rw/zd_usb.c  |  2 +-
 drivers/nfc/nfcmrvl/fw_dnld.c                 |  8 +++---
 drivers/power/supply/mt6370-charger.c         |  2 +-
 drivers/remoteproc/imx_rproc.c                |  2 +-
 drivers/remoteproc/stm32_rproc.c              |  2 +-
 drivers/scsi/fcoe/fcoe_sysfs.c                |  7 +-----
 drivers/scsi/hisi_sas/hisi_sas_main.c         |  2 +-
 drivers/scsi/hosts.c                          |  9 +++----
 drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c      |  4 +--
 drivers/scsi/libsas/sas_init.c                |  9 +++----
 drivers/scsi/mpi3mr/mpi3mr_fw.c               |  4 +--
 drivers/scsi/mpt3sas/mpt3sas_base.c           |  4 +--
 drivers/scsi/myrb.c                           |  5 ++--
 drivers/scsi/myrb.h                           |  1 -
 drivers/scsi/myrs.c                           |  5 ++--
 drivers/scsi/myrs.h                           |  1 -
 drivers/scsi/qedf/qedf_main.c                 | 17 +++++--------
 drivers/scsi/qedi/qedi_main.c                 |  8 +++---
 drivers/scsi/qla2xxx/qla_os.c                 | 10 ++++----
 drivers/scsi/qla4xxx/ql4_os.c                 |  5 ++--
 drivers/scsi/scsi_transport_fc.c              |  4 +--
 drivers/scsi/snic/snic_main.c                 |  5 ++--
 drivers/scsi/stex.c                           |  6 ++---
 drivers/scsi/vmw_pvscsi.c                     |  8 ++----
 drivers/tty/serial/max3100.c                  |  4 +--
 drivers/ufs/core/ufshcd.c                     | 13 +++-------
 drivers/usb/typec/tcpm/fusb302.c              |  2 +-
 drivers/usb/typec/ucsi/ucsi.c                 |  9 ++-----
 fs/smb/client/smbdirect.c                     |  3 +--
 include/linux/mlx5/driver.h                   |  5 ----
 include/linux/workqueue.h                     | 15 +++++------
 include/scsi/fcoe_sysfs.h                     |  1 -
 include/scsi/scsi_host.h                      |  1 -
 include/scsi/scsi_transport_fc.h              |  3 ---
 mm/z3fold.c                                   |  4 +--
 net/mac802154/main.c                          |  7 +++---
 net/nfc/nci/core.c                            | 13 +++++-----
 66 files changed, 135 insertions(+), 223 deletions(-)