Skip to content

RFC nfsd: provide simpler interface for LOCALIO access

NeilBrown linux-nfs oe-kbuild-all oe-lkp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6nfsd: introduce __fh_verify which takes explicit nfsd_net argfs/nfsd/export.c fs/nfsd/export.h fs/nfsd/nfs4proc.c +1 more+26 -121 reply
2/6nfsd: add cred parameter to __fh_verify()fs/nfsd/auth.c fs/nfsd/auth.h fs/nfsd/export.h +5 more+41 -311 reply
3/6nfsd: pass nfs_vers explicitly to __fh_verify()fs/nfsd/nfsfh.c+21 -151 reply
4/6nfsd: pass client explicitly to __fh_verify()fs/nfsd/export.c fs/nfsd/export.h fs/nfsd/nfs4proc.c +1 more+18 -121 reply
5/6nfsd: __fh_verify now treats NULL rqstp as a trusted connection.fs/nfsd/export.c fs/nfsd/nfsfh.c+11 -50 replies
6/6nfsd: add nfsd_file_acquire_local().fs/nfsd/filecache.c fs/nfsd/filecache.h fs/nfsd/nfsfh.c +1 more+59 -63 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6 RFC] nfsd: provide simpler interface for LOCALIO access

The purpose of this series is to provide an iterface to the filecache which can be used without a struct svc_rqst, and without any xprt.

This interface is realised in the final patch as nfsd_file_acquire_local().

That function currently takes and nfs_vers option. That was a natural fallout of the refactorisation that lead here, but it probably isn't wanted. I need to review exactly what effect it has - mostly it is about error code choice I think.

The function also takess a 'struct auth_domain*'. It is not clear how a caller would get hold of such a thing. I suspect that the server should register a "local-io" auth_domain in the nfsd_net, and it should be used here.

Comments on design and implementation most welcome.

Thanks,
NeilBrown

[PATCH 1/6] nfsd: introduce __fh_verify which takes explicit nfsd_net [PATCH 2/6] nfsd: add cred parameter to __fh_verify() [PATCH 3/6] nfsd: pass nfs_vers explicitly to __fh_verify() [PATCH 4/6] nfsd: pass client explicitly to __fh_verify() [PATCH 5/6] nfsd: __fh_verify now treats NULL rqstp as a trusted [PATCH 6/6] nfsd: add nfsd_file_acquire_local().