Simplify event handling logic in input core
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest7 patches 8 repliesIn review
- v14 patches 7 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | Input: evdev - remove ->event() methoddrivers/ | +0 | 1 reply | |
| 2/7 | Input: make sure input handlers define only one processing methoddrivers/ | +24 | 1 reply | |
| 3/7 | Input: make events() method return number of events processeddrivers/ include/ | +8 | 1 reply | |
| 4/7 | Input: simplify event handling logicdrivers/ | +68 | 1 reply | |
| 5/7 | Input: rearrange input_alloc_device() to prepare for preallocating of valsdrivers/ | +22 | 1 reply | |
| 6/7 | Input: preallocate memory to hold event valuesdrivers/ | +44 | 1 reply | |
| 7/7 | Input: do not check number of events in input_pass_values()drivers/ | +0 | 1 reply |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Benjamin Tissoires | Jeff LaBundy |
|---|---|---|
| Series | R-b | |
| 1/7 | R-b | |
| 2/7 | R-b | |
| 3/7 | R-b | |
| 4/7 | R-b | |
| 5/7 | R-b | |
| 6/7 | R-b | |
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/7] Simplify event handling logic in input core
This series tries to untangle somewhat convoluted logic in the input event processing in the input core by realizing that input handler can be either a filter, or a handler that handles a single event at a time, or a handler that can handle a sequence of events, but should not mix the 3 behaviors in one handler. This allows us to reduce both filter functionality and single-event handling functionality to batch handling and have the main event handling path to only deal with input_handle->events() batch method.
v2: addressed comments from Benjamin:
- added missing patch to remove evdev->event() implementation
- allow not specifying any event handling method to satisfy kgdboc handler
- expanded comment on order of running input handlers when passing events
- split pre-allocation into 2 patches and moved removal of count check into 3rd patch.
Dmitry Torokhov (7):
Input: evdev - remove ->event() method
Input: make sure input handlers define only one processing method
Input: make events() method return number of events processed
Input: simplify event handling logic
Input: rearrange input_alloc_device() to prepare for preallocating of vals
Input: preallocate memory to hold event values
Input: do not check number of events in input_pass_values()
drivers/input/evdev.c | 16 +-- drivers/input/input.c | 230 ++++++++++++++++++++++++++++-------------- include/linux/input.h | 7 +- 3 files changed, 163 insertions(+), 90 deletions(-)
Signature · 1 line
2.45.2.803.g4e1b14247a-goog