Skip to content

igc bug fixes related to qbv_count usage

Faizal Rahim intel-wired-lan lkml netdev oe-kbuild-all stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 11 repliesIn review
  2. v14 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- Instead of casting to bool, use !! (Simon)
- Simplify new functions created. Instead of if.. return true, else return false, use single return. (Simon)
- Remove patch "igc: Remove unused qbv_coun" from this series which is targeting to iwl-net. This patch will be sent to iwl-next. (Simon)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3igc: Fix qbv_config_change_errors logicsdrivers/net/ethernet/intel/igc/igc_main.c drivers/net/ethernet/intel/igc/igc_tsn.c drivers/net/ethernet/intel/igc/igc_tsn.h+15 -102 replies
2/3igc: Fix reset adapter logics when tx mode changedrivers/net/ethernet/intel/igc/igc_tsn.c+20 -37 replies
3/3igc: Fix qbv tx latency by setting gtxoffsetdrivers/net/ethernet/intel/igc/igc_tsn.c+1 -12 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchSimon HormanVinicius Costa GomesMor Bar-Gabay
1/3R-b A-b T-b
2/3R-b A-b A-b T-b
3/3R-b A-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH iwl-net v2 0/3] igc bug fixes related to qbv_count usage

These igc bug fixes are sent as a patch series because:

1. The two patches below remove the reliance on using the qbv_count field. "igc: Fix qbv_config_change_errors logics"
"igc: Fix reset adapter logics when tx mode change"

qbv_count field will be removed in future patch via iwl-next.

2. The patch "igc: Fix qbv tx latency by setting gtxoffset" reuse the function igc_tsn_will_tx_mode_change() which was created in the patch:
"igc: Fix reset adapter logics when tx mode change"

v1: https://patchwork.kernel.org/project/netdevbpf/cover/[email protected]/

Changelog:
v1 -> v2
- Instead of casting to bool, use !! (Simon)
- Simplify new functions created. Instead of if.. return true, else return false, use single return. (Simon)
- Remove patch "igc: Remove unused qbv_coun" from this series which is targeting to iwl-net. This patch will be sent to iwl-next. (Simon)

Faizal Rahim (3):
igc: Fix qbv_config_change_errors logics
igc: Fix reset adapter logics when tx mode change
igc: Fix qbv tx latency by setting gtxoffset

 drivers/net/ethernet/intel/igc/igc_main.c |  8 +++--
 drivers/net/ethernet/intel/igc/igc_tsn.c  | 41 ++++++++++++++++-------
 drivers/net/ethernet/intel/igc/igc_tsn.h  |  1 +
 3 files changed, 36 insertions(+), 14 deletions(-)

--
2.25.1