Skip to content

Offset correction for apds9960

Abhash Jha linux-iio lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest1 patch 1 replyIn review
  2. v21 patch 2 repliesSuperseded
  3. v11 patch 1 replySuperseded

Changes in v3 from the cover letter

- Some code refactoring based on comments in v2
- Link to v2 : https://lore.kernel.org/linux-iio/20240803145836.4e372899@jic23-huawei/T/#u

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1iio: light: apds9960: Add proximity and gesture offset calibrationdrivers/iio/light/apds9960.c+54 -11 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/1] Offset correction for apds9960

Hello,
This patch adds support for doing internal offset correction for the proximity and gesture circuits. The correction value is written to the respective POFFSET_x or GOFFSET_x register depending on which direction we want to perform this calibration.
For the proximity channel we apply the offset to both the DL and UR directions. And for the gesture channel we apply the offset to the respective U, D, L, R direction.

Changes in v3:
- Some code refactoring based on comments in v2
- Link to v2 : https://lore.kernel.org/linux-iio/20240803145836.4e372899@jic23-huawei/T/#u

Changes in v2:
- Used IIO_CHAN_INFO_CALIBBIAS instead of exposing custom sysfs attributes
- Used enum to choose between correct the offset registers
- Corrected the formatting and style errors
- Link to v1 : https://lore.kernel.org/linux-iio/20240707171357.709d9e35@jic23-huawei/

Abhash Jha (1):
iio: light: apds9960: Add proximity and gesture offset calibration

 drivers/iio/light/apds9960.c | 55 +++++++++++++++++++++++++++++++++++-
 1 file changed, 54 insertions(+), 1 deletion(-)
Signature · 1 line
2.43.0