Skip to content

hw/sd/sdcard: Cleanups before adding eMMC support

Philippe Mathieu-Daudé qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v46 Latest5 patches 8 repliesIn review
  2. v453 patches 3 repliesSuperseded
  3. v443 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v432 patches2 repliesSuperseded

Changes in v46 from the cover letter

- RAZ/WI on GEN_CMD (Luc & Manos)
- Rename sd_cmd_SEND_OP_COND
- Introduce TYPE_SDMMC_COMMON

Patches in v46 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5hw/sd/sdcard: Use spec v3.01 by defaulthw/core/machine.c hw/sd/sd.c+2 -10 replies
2/5hw/sd/sdcard: Add sd_cmd_GEN_CMD handler (CMD56)hw/sd/sd.c+20 -340 replies
3/5hw/sd/sdcard: Rename sd_cmd_SEND_OP_COND handlerhw/sd/sd.c+2 -21 reply
4/5hw/sd/sdcard: Introduce set_csd/set_cid handlershw/sd/sd.c include/hw/sd/sd.h+7 -21 reply
5/5hw/sd/sdcard: Extract TYPE_SDMMC_COMMON from TYPE_SD_CARDhw/sd/core.c hw/sd/sd.c hw/sd/sdmmc-internal.h+52 -303 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchCédric Le GoaterAndrew Jeffery
SeriesT-b T-b
1/5R-b
2/5
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v46 thread

Cover letter [PATCH v46 0/5] hw/sd/sdcard: Cleanups before adding eMMC support

(patches from v42 already reviewed not reposted)

Since v45:
- RAZ/WI on GEN_CMD (Luc & Manos)
- Rename sd_cmd_SEND_OP_COND
- Introduce TYPE_SDMMC_COMMON

Philippe Mathieu-Daudé (5):
hw/sd/sdcard: Use spec v3.01 by default hw/sd/sdcard: Add sd_cmd_GEN_CMD handler (CMD56) hw/sd/sdcard: Rename sd_cmd_SEND_OP_COND handler hw/sd/sdcard: Introduce set_csd/set_cid handlers hw/sd/sdcard: Extract TYPE_SDMMC_COMMON from TYPE_SD_CARD

 hw/sd/sdmmc-internal.h |   3 ++
 include/hw/sd/sd.h     |   2 +
 hw/core/machine.c      |   1 +
 hw/sd/core.c           |  29 ++++++-----
 hw/sd/sd.c             | 113 ++++++++++++++++++++++-------------------
 5 files changed, 81 insertions(+), 67 deletions(-)
Signature · 1 line
2.41.0