Skip to content

Simplify multiple create*_workqueue() invocations

Bart Van Assche linux-scsi 3 versions – Applied

Status from this message: Applied to 6.12/scsi-staging, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest18 patches 2 repliesApplied
  2. v218 patches 9 repliesSuperseded
  3. v118 patches 3 repliesSuperseded

Changes in v3 from the cover letter

- Added more Reviewed-by tags.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/18scsi: Expand all create*_workqueue() invocationsdrivers/scsi/bfa/bfad_im.c drivers/scsi/bnx2fc/bnx2fc_fcoe.c drivers/scsi/device_handler/scsi_dh_rdac.c +22 more+64 -430 replies
2/18scsi: mptfusion: Simplify the alloc*_workqueue() invocationsdrivers/message/fusion/mptbase.c drivers/message/fusion/mptbase.h drivers/message/fusion/mptfc.c+5 -150 replies
3/18scsi: be2iscsi: Simplify an alloc_workqueue() invocationdrivers/scsi/be2iscsi/be_main.c+2 -40 replies
4/18scsi: bfa: Simplify an alloc_ordered_workqueue() invocationdrivers/scsi/bfa/bfad_im.c drivers/scsi/bfa/bfad_im.h+2 -50 replies
5/18scsi: esas2r: Simplify an alloc_ordered_workqueue() invocationdrivers/scsi/esas2r/esas2r.h drivers/scsi/esas2r/esas2r_init.c+2 -50 replies
6/18scsi: fcoe: Simplify alloc_ordered_workqueue() invocationsdrivers/scsi/fcoe/fcoe_sysfs.c include/scsi/fcoe_sysfs.h+5 -150 replies
7/18scsi: ibmvscsi_tgt: Simplify an alloc_workqueue() invocationdrivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c+2 -30 replies
8/18scsi: mpi3mr: Simplify an alloc_ordered_workqueue() invocationdrivers/scsi/mpi3mr/mpi3mr.h drivers/scsi/mpi3mr/mpi3mr_os.c+1 -50 replies
9/18scsi: mpt3sas: Simplify an alloc_ordered_workqueue() invocationdrivers/scsi/mpt3sas/mpt3sas_base.h drivers/scsi/mpt3sas/mpt3sas_scsih.c+2 -60 replies
10/18scsi: myrb: Simplify an alloc_ordered_workqueue() invocationdrivers/scsi/myrb.c drivers/scsi/myrb.h+2 -50 replies
11/18scsi: myrs: Simplify an alloc_ordered_workqueue() invocationdrivers/scsi/myrs.c drivers/scsi/myrs.h+2 -50 replies
12/18scsi: qedf: Simplify alloc_workqueue() invocationsdrivers/scsi/qedf/qedf_main.c+6 -90 replies
13/18scsi: qedi: Simplify an alloc_workqueue() invocationdrivers/scsi/qedi/qedi_main.c+3 -30 replies
14/18scsi: snic: Simplify alloc_workqueue() invocationsdrivers/scsi/snic/snic_main.c+2 -40 replies
15/18scsi: scsi_transport_fc: Simplify alloc_workqueue() invocationsdrivers/scsi/scsi_transport_fc.c include/scsi/scsi_transport_fc.h+3 -140 replies
16/18scsi: stex: Simplify an alloc_ordered_workqueue() invocationdrivers/scsi/stex.c+2 -50 replies
17/18scsi: ufs: Simplify alloc*_workqueue() invocationdrivers/ufs/core/ufshcd.c+7 -160 replies
18/18scsi: core: Simplify an alloc_workqueue() invocationdrivers/scsi/hosts.c include/scsi/scsi_host.h+4 -60 replies

Reviews trailers per patch

5 of 18 patches have a Reviewed-by or Acked-by.

PatchHannes ReineckeManivannan SadhasivamPeter Wang
1/18R-b
2/18
3/18
4/18
5/18
6/18R-b
7/18
8/18
9/18
10/18R-b
11/18R-b
12/18
13/18
14/18
15/18
16/18
17/18R-b R-b
18/18

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/18] Simplify multiple create*_workqueue() invocations

Hi Martin,

Multiple SCSI drivers use snprintf() to format a workqueue name before invoking one of the create*_workqueue() macros. This patch series simplifies such code by passing the format string and arguments to alloc_workqueue(). Additionally, the structure members that are only used as a temporary buffer for formatting workqueue names are removed. Please consider this patch series for the next merge window.

Thanks,

Bart.

Changes compared to v2:
- Added more Reviewed-by tags.

Changes compared to v1:
- Added several Reviewed-by tags.

Bart Van Assche (18):
scsi: Expand all create*_workqueue() invocations
scsi: mptfusion: Simplify the alloc*_workqueue() invocations
scsi: be2iscsi: Simplify an alloc_workqueue() invocation
scsi: bfa: Simplify an alloc_ordered_workqueue() invocation
scsi: esas2r: Simplify an alloc_ordered_workqueue() invocation
scsi: fcoe: Simplify alloc_ordered_workqueue() invocations
scsi: ibmvscsi_tgt: Simplify an alloc_workqueue() invocation
scsi: mpi3mr: Simplify an alloc_ordered_workqueue() invocation
scsi: mpt3sas: Simplify an alloc_ordered_workqueue() invocation
scsi: myrb: Simplify an alloc_ordered_workqueue() invocation
scsi: myrs: Simplify an alloc_ordered_workqueue() invocation
scsi: qedf: Simplify alloc_workqueue() invocations
scsi: qedi: Simplify an alloc_workqueue() invocation
scsi: snic: Simplify alloc_workqueue() invocations
scsi: scsi_transport_fc: Simplify alloc_workqueue() invocations
scsi: stex: Simplify an alloc_ordered_workqueue() invocation
scsi: ufs: Simplify alloc*_workqueue() invocation
scsi: core: Simplify an alloc_workqueue() invocation

 drivers/message/fusion/mptbase.c            | 10 +++-------
 drivers/message/fusion/mptbase.h            |  3 ---
 drivers/message/fusion/mptfc.c              |  7 ++-----
 drivers/scsi/be2iscsi/be_main.c             |  6 ++----
 drivers/scsi/bfa/bfad_im.c                  |  5 ++---
 drivers/scsi/bfa/bfad_im.h                  |  1 -
 drivers/scsi/bnx2fc/bnx2fc_fcoe.c           |  4 ++--
 drivers/scsi/device_handler/scsi_dh_rdac.c  |  3 ++-
 drivers/scsi/elx/efct/efct_lio.c            |  3 ++-
 drivers/scsi/esas2r/esas2r.h                |  1 -
 drivers/scsi/esas2r/esas2r_init.c           |  5 ++---
 drivers/scsi/fcoe/fcoe_sysfs.c              | 18 +++++------------
 drivers/scsi/fnic/fnic_main.c               |  6 ++++--
 drivers/scsi/hisi_sas/hisi_sas_main.c       |  3 ++-
 drivers/scsi/hosts.c                        |  9 ++++-----
 drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c    |  5 ++---
 drivers/scsi/libfc/fc_exch.c                |  3 ++-
 drivers/scsi/libfc/fc_rport.c               |  3 ++-
 drivers/scsi/libsas/sas_init.c              |  4 ++--
 drivers/scsi/megaraid/megaraid_sas_fusion.c |  4 ++--
 drivers/scsi/mpi3mr/mpi3mr.h                |  2 --
 drivers/scsi/mpi3mr/mpi3mr_fw.c             |  4 ++--
 drivers/scsi/mpi3mr/mpi3mr_os.c             |  4 +---
 drivers/scsi/mpt3sas/mpt3sas_base.c         |  4 ++--
 drivers/scsi/mpt3sas/mpt3sas_base.h         |  4 +---
 drivers/scsi/mpt3sas/mpt3sas_scsih.c        |  4 +---
 drivers/scsi/myrb.c                         |  5 ++---
 drivers/scsi/myrb.h                         |  1 -
 drivers/scsi/myrs.c                         |  5 ++---
 drivers/scsi/myrs.h                         |  1 -
 drivers/scsi/qedf/qedf_main.c               | 20 +++++++++----------
 drivers/scsi/qedi/qedi_main.c               |  8 +++++---
 drivers/scsi/qla2xxx/qla_os.c               |  6 ++++--
 drivers/scsi/qla4xxx/ql4_os.c               |  2 +-
 drivers/scsi/scsi_transport_fc.c            | 11 +++--------
 drivers/scsi/snic/snic_main.c               |  8 ++++----
 drivers/scsi/stex.c                         |  6 ++----
 drivers/scsi/vmw_pvscsi.c                   |  3 ++-
 drivers/ufs/core/ufshcd.c                   | 22 +++++++--------------
 include/scsi/fcoe_sysfs.h                   |  2 --
 include/scsi/scsi_host.h                    |  1 -
 include/scsi/scsi_transport_fc.h            |  6 ------
 42 files changed, 90 insertions(+), 142 deletions(-)