Skip to content

eth: bnxt: use the new RSS API

Jakub Kicinski llvm netdev oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11net: ethtool: let drivers remove lost RSS contextsinclude/linux/ethtool.h net/ethtool/rss.c+16 -03 replies
2/11net: ethtool: let driver declare max size of RSS indir table and keyinclude/linux/ethtool.h net/ethtool/ioctl.c+44 -221 reply
2/11net: ethtool: let drivers declare max size of RSS indir table and keyinclude/linux/ethtool.h net/ethtool/ioctl.c+44 -221 reply
3/11eth: bnxt: allow deleting RSS contexts when the device is downdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c+10 -60 replies
4/11eth: bnxt: move from .set_rxfh to .create_rxfh_context and friendsdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c+75 -453 replies
5/11eth: bnxt: remove rss_ctx_bmapdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c+2 -180 replies
6/11eth: bnxt: depend on core cleaning up RSS contextsdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c+6 -90 replies
7/11eth: bnxt: use context priv for struct bnxt_rss_ctxdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c+9 -300 replies
8/11eth: bnxt: use the RSS context XArray instead of the local listdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c+26 -280 replies
9/11eth: bnxt: bump the entry size in indir tables to u32drivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c+9 -94 replies
10/11eth: bnxt: use the indir table from ethtool contextdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +1 more+35 -363 replies
11/11eth: bnxt: pad out the correct indirection tabledrivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c+1 -10 replies

Reviews trailers per patch

1 of 12 patches has a Reviewed-by or Acked-by.

PatchPrzemek Kitszel
1/11
2/11
2/11
3/11
4/11
5/11
6/11
7/11
8/11
9/11R-b
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 00/11] eth: bnxt: use the new RSS API

Convert bnxt from using the set_rxfh API to separate create/modify/remove callbacks.

Two small extensions to the core APIs are necessary:
- the ability to discard contexts if for some catastrophic reasons device can no longer provide them;
- the ability to reserve space in the context for RSS table growth.

The driver is adjusted to store indirection tables on u32 to make it easier to use core structs directly.

With that out of the way the conversion is fairly straightforward.

Jakub Kicinski (11):
net: ethtool: let drivers remove lost RSS contexts
net: ethtool: let drivers declare max size of RSS indir table and key
eth: bnxt: allow deleting RSS contexts when the device is down
eth: bnxt: move from .set_rxfh to .create_rxfh_context and friends
eth: bnxt: remove rss_ctx_bmap
eth: bnxt: depend on core cleaning up RSS contexts
eth: bnxt: use context priv for struct bnxt_rss_ctx
eth: bnxt: use the RSS context XArray instead of the local list
eth: bnxt: bump the entry size in indir tables to u32
eth: bnxt: use the indir table from ethtool context
eth: bnxt: pad out the correct indirection table

 drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 115 +++++--------
 drivers/net/ethernet/broadcom/bnxt/bnxt.h     |  14 +-
 .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 159 ++++++++++--------
 include/linux/ethtool.h                       |  25 +--
 net/ethtool/ioctl.c                           |  46 +++--
 net/ethtool/rss.c                             |  14 ++
 6 files changed, 201 insertions(+), 172 deletions(-)
Signature · 1 line
2.45.2