Enable FRED earlier
Status from this message: The following commit has been merged into the x86/fred branch of tip:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 8 repliesApplied
- v14 patches 22 repliesSuperseded
Changes in v2 from the cover letter
* Drop the patch that changes wrmsrl() to wrmsrns().
* Use strncmp() instead of strcmp().
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | x86/fred: Parse cmdline param "fred=" in cpu_parse_early_param()arch/ arch/ | +5 | 3 replies | |
| 2/3 | x86/fred: Split FRED RSP initialization into a separate functionarch/ arch/ arch/ | +25 | 0 replies | |
| 3/3 | x86/fred: Enable FRED right after init_mem_mapping()arch/ arch/ arch/ +1 more | +21 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/3] Enable FRED earlier
Wenlong Hou from Ant group reported two problems during the FRED initialization:
https://lore.kernel.org/lkml/[email protected]/
The first problem is that spurious_interrupt() gets called on the HYPERVISOR_CALLBACK_VECTOR vector. Because kvm_guest_init(), being executed way before trap_init() in which it is decided that whether FRED will be enabled or not, calls sysvec_install() to install HYPERVISOR_CALLBACK_VECTOR's interrupt handler into FRED system vector dispatch table or IDT depending on whether FRED is enabled.
The other problem is that the #PF handler gets a wrong faulting address from the stack instead of CR2 before FRED is enabled. Because the #PF handler fetches its faulting addresss from the stack or CR2 based on whether FRED is available rather than active.
This patchset fixes the 2 problems with suggestions from tglx:
1) Parse cmdline param "fred=" in cpu_parse_early_param() to minimize the gap mentioned above, before kvm_guest_init().
2) Enable FRED right after init_mem_mapping() to switch to FRED from early IDT ASAP, avoid intermediately using the IDT #PF handler.
Link to v1:
https://lore.kernel.org/lkml/[email protected]/
Changes since v1:
* Drop the patch that changes wrmsrl() to wrmsrns().
* Use strncmp() instead of strcmp().
Xin Li (Intel) (3):
x86/fred: Parse cmdline param "fred=" in cpu_parse_early_param() x86/fred: Split FRED RSP initialization into a separate function x86/fred: Enable FRED right after init_mem_mapping()
arch/x86/include/asm/fred.h | 2 ++ arch/x86/kernel/cpu/common.c | 9 ++++++--- arch/x86/kernel/fred.c | 28 +++++++++++++++++++--------- arch/x86/kernel/setup.c | 11 ++++++++++- arch/x86/kernel/smpboot.c | 6 ++++++ arch/x86/kernel/traps.c | 30 ++++-------------------------- 6 files changed, 47 insertions(+), 39 deletions(-)
base-commit: aa9d8caba6e40b0b02a6f2b5f2bd9177cd76cacf
Signature · 1 line
2.45.2