Skip to content

object,accel-system: allow Accel type globals

Daniel Henrique Barboza qemu-devel 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 7 repliesIn review
  2. v12 patches 1 replySuperseded

Changes in v2 from the cover letter

- patch 1:
- move all globals related function and declarations from qdev files
to object
- v1 review: https://lore.kernel.org/qemu-devel/[email protected]/

[1] https://lore.kernel.org/qemu-devel/[email protected]/

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2qom/object, qdev: move globals functions to object.chw/core/cpu-common.c hw/core/qdev-properties-system.c hw/core/qdev-properties.c +9 more+114 -1133 replies
2/2qom/object, accel-system: add support to Accel globalsaccel/accel-system.c qom/object.c+25 -114 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] object,accel-system: allow Accel type globals

Hi,

In this new version we followed Daniel's suggestion in the v1 review [1] and moved all 'globals' related functions and definitions from qdev to object. Functions were renamed as follows:

- qdev_prop_register_global() is now object_prop_register_global()
- qdev_find_global_prop() is now object_find_global_prop()
- qdev_prop_check_globals() is now object_prop_check_globals()
- qdev_prop_set_globals() is now object_prop_set_globals()

The API change that were done in patch 1 is now being done on object_prop_set_globals().

It crossed my mind to rename test-qdev-global-props.c to test-object-global-props.c, but since the file is dealing exclusively with qdev related tests I think the rename was unneeded.

No other changes made.

Changes from v1:
- patch 1:
- move all globals related function and declarations from qdev files
to object
- v1 review: https://lore.kernel.org/qemu-devel/[email protected]/

[1] https://lore.kernel.org/qemu-devel/[email protected]/

Daniel Henrique Barboza (2):
qom/object, qdev: move globals functions to object.c qom/object, accel-system: add support to Accel globals

 accel/accel-system.c                |  2 +
 hw/core/cpu-common.c                |  2 +-
 hw/core/qdev-properties-system.c    |  2 +-
 hw/core/qdev-properties.c           | 71 -------------------------
 hw/core/qdev.c                      |  2 +-
 include/hw/qdev-core.h              | 27 ----------
 include/hw/qdev-properties.h        |  5 --
 include/qom/object.h                | 34 ++++++++++++
 qom/object.c                        | 82 +++++++++++++++++++++++++++++
 system/vl.c                         |  6 +--
 target/i386/cpu.c                   |  2 +-
 target/sparc/cpu.c                  |  2 +-
 tests/unit/test-qdev-global-props.c |  4 +-
 13 files changed, 128 insertions(+), 113 deletions(-)
Signature · 1 line
2.45.2